openstack
/
governance
Code Issues Proposed changes

tools: report dissenting votes for project-update 

If there is a project-update change where we have a -1 code review,
we should probably put that into account as it might mean that it's
not the good time to land it.

Change-Id: If95af41005a0b328ffbda74f6b56b00d68a98eea
This commit is contained in:
Mohammed Naser 2019-05-22 21:59:06 +08:00
parent 173df219ac
commit b4a104745c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/check_review_status.py
View File

@ -344,7 +344,7 @@ def get_one_status(change, delegates, tc_members):
# At least 7 days old.
earliest = str(latest_created.date() + datetime.timedelta(8))
if votes[-1]:
if votes[-1] or code_reviews[-1]:
can_approve = 'dissenting votes'
elif age <= datetime.timedelta(7):
can_approve = 'too soon'