openstack/governance
Code Issues Proposed changes
f563e44e49
governance/1ccaefcf1be727191b36368f475520cefa3d4735
Gerrit User 8556 16aa302671 Update patch set 6 
Patch Set 6:

(3 comments)

Patch-set: 6
2024-03-05 19:48:21 +00:00

313 lines
9.5 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "b4c85b4e_7567ed62",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 10342
},
"writtenOn": "2024-02-29T20:46:58Z",
"side": 1,
"message": "I like labeling it as \"Advance/Unstable Testing\".",
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c6322f67_4e0bcdad",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 11604
},
"writtenOn": "2024-03-01T00:13:56Z",
"side": 1,
"message": "im still a little sad not to see 3.12 mentioned in the advanced testing section but lets just move forward this this.",
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7b6d27b9_2e40f314",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 5314
},
"writtenOn": "2024-03-01T21:41:32Z",
"side": 1,
"message": "Assuming that the typo Slawek pointed out on line 49 refers to Python 3.9, I\u0027m ok with this. I agree with Sean that it would have been nice to include python 3.12 in the advance testing section, but James pointed out that python 3.12 will be the default python in Ubuntu 24.04 (which is mentioned there), so I guess my concern is addressed implicitly.",
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d993c5d9_eb93229b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 13252
},
"writtenOn": "2024-03-05T08:57:44Z",
"side": 1,
"message": "I\u0027m still fine with this, thx",
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "370fdcab_9c51b6ab",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 17685
},
"writtenOn": "2024-03-05T17:09:35Z",
"side": 1,
"message": "Thanks Ghanshyam! LGTM, renders well: https://b631ee6275bb7b37dd71-55de238001b0f469b6551044671dd544.ssl.cf2.rackcdn.com/908862/5/check/openstack-tox-docs/80d37d1/docs/reference/runtimes/2024.2.html",
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5de69ebe_0d81a232",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 26,
"author": {
"id": 11604
},
"writtenOn": "2024-03-01T00:13:56Z",
"side": 1,
"message": "strictly speaking this is python 3.12 which as released on Oct. 2, 2023\n\nhttps://www.python.org/downloads/release/python-3120/\n\nbut fine if we are not comforatble sayign that explictly then lets proceed and ad the extra testing in project that care to enabel it.",
"range": {
"startLine": 25,
"startChar": 34,
"endLine": 26,
"endChar": 7
},
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "84f9901b_31b6b727",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 26,
"author": {
"id": 8556
},
"writtenOn": "2024-03-05T19:48:21Z",
"side": 1,
"message": "Done",
"parentUuid": "5de69ebe_0d81a232",
"range": {
"startLine": 25,
"startChar": 34,
"endLine": 26,
"endChar": 7
},
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ee1e8db6_97d4e208",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 34,
"author": {
"id": 7166
},
"writtenOn": "2024-03-05T08:45:13Z",
"side": 1,
"message": "femtonit : criterias (plural)",
"range": {
"startLine": 34,
"startChar": 13,
"endLine": 34,
"endChar": 21
},
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a79ec6b0_1f11fec4",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 34,
"author": {
"id": 13252
},
"writtenOn": "2024-03-05T08:57:44Z",
"side": 1,
"message": "the singular is \"criterium\" and \"criteria\" already is plural (at least in latin, but I don\u0027t think english can be much off. or does it?)",
"parentUuid": "ee1e8db6_97d4e208",
"range": {
"startLine": 34,
"startChar": 13,
"endLine": 34,
"endChar": 21
},
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b41b7f9b_f6765914",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 49,
"author": {
"id": 11975
},
"writtenOn": "2024-03-01T07:13:50Z",
"side": 1,
"message": "isn\u0027t something missing here?",
"range": {
"startLine": 49,
"startChar": 9,
"endLine": 49,
"endChar": 12
},
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a2ebad69_a8673568",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 49,
"author": {
"id": 8556
},
"writtenOn": "2024-03-04T19:52:36Z",
"side": 1,
"message": "yes, I missed to fix it, it needs to be python 3.9. I will fix this in follow up to avoid resetting the votes here.",
"parentUuid": "b41b7f9b_f6765914",
"range": {
"startLine": 49,
"startChar": 9,
"endLine": 49,
"endChar": 12
},
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b847ca82_f8382319",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 49,
"author": {
"id": 8556
},
"writtenOn": "2024-03-04T23:34:36Z",
"side": 1,
"message": "fixing it in https://review.opendev.org/c/openstack/governance/+/911011",
"parentUuid": "a2ebad69_a8673568",
"range": {
"startLine": 49,
"startChar": 9,
"endLine": 49,
"endChar": 12
},
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "243f880c_01a50863",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 49,
"author": {
"id": 8556
},
"writtenOn": "2024-03-05T19:48:21Z",
"side": 1,
"message": "Done",
"parentUuid": "b847ca82_f8382319",
"range": {
"startLine": 49,
"startChar": 9,
"endLine": 49,
"endChar": 12
},
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "057dca52_a878efdf",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 78,
"author": {
"id": 4393
},
"writtenOn": "2024-02-29T21:33:01Z",
"side": 1,
"message": "Thanks for adding this. TBH, it seems like too much of a footnote that will be easy to just skim over while reading this and won\u0027t really achieve the level of \"seriously dude, iceberg ahead\" that we need. But, whatever, it\u0027s an iceberg whether we admit it or not and I\u0027m a bit tired of the argument.",
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d4ab5370_11a3a51d",
"filename": "reference/runtimes/2024.2.rst",
"patchSetId": 5
},
"lineNbr": 78,
"author": {
"id": 8556
},
"writtenOn": "2024-02-29T21:50:22Z",
"side": 1,
"message": "I kept it at the same level as of distribution and python runtime section but need to add it at the end so that we can add both distro as well as python versions here",
"parentUuid": "057dca52_a878efdf",
"revId": "1ccaefcf1be727191b36368f475520cefa3d4735",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink