openstack
/
hacking
Code Issues Proposed changes

Bump pep8, pyflakes and flake8 versions 

Since newer versions of each package can either break
hacking(flake8, pep8) or introduce new rules and because we gate on the
output of hacking, we pin these dependencies to specific versions.

* Set pyflakes to the newest version: 0.8.1
* Set flake8 to to the newest version: 2.1.0
* Set pep8 to 1.4.6, since newer version (1.5.1) breaks hacking and will
  require additional work to support it. Will be addressed in a future
  patch.

Fix code to pass new version of pep8.

Change-Id: Ia3495102a9d096c09802b9c079a8dc7ec1f65530
This commit is contained in:
Joe Gordon 2014-04-02 18:03:38 -07:00
parent fe5d825d9a
commit 297b89aad1
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hacking/core.py
View File

@ -100,7 +100,7 @@ def import_normalize(line):
split_line[2] == "import" and split_line[3] != "*" and
split_line[1] != "__future__" and
(len(split_line) == 4 or
(len(split_line) == 6 and split_line[4] == "as"))):
(len(split_line) == 6 and split_line[4] == "as"))):
return "import %s.%s" % (split_line[1], split_line[3])
else:
return line

6
requirements.txt
View File

@ -1,7 +1,7 @@
pbr>=0.6,<1.0
pep8==1.4.5
pyflakes>=0.7.2,<0.7.4
flake8==2.0
pep8==1.4.6
pyflakes==0.8.1
flake8==2.1.0
six>=1.5.2