From f5b17319335271d7e4b58a8b8efa28d5ad00ee92 Mon Sep 17 00:00:00 2001 From: Paul Carver Date: Wed, 15 Feb 2017 09:18:44 -0500 Subject: [PATCH] Disambiguate the hacking rules for third party imports There is some inconsistency across existing code in whether OpenStack projects such as oslo and neutron_lib are considered "third party" or "project imports". This commit clarifies the guideline. If the popular sentiment is the opposite of what I've written then I can change the wording to say that, but either way the style guide should state clearly whether "other" OpenStack projects are "project" or "third party". Change-Id: I6d89eefdef9f3b594a65aa73b7464bbc1f18306d --- HACKING.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/HACKING.rst b/HACKING.rst index f8ca7db2..51c4c4d9 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -58,6 +58,9 @@ Imports - [H306] Alphabetically order your imports by the full module path. Organize your imports according to the `Import order template`_ and `Real-world Import Order Examples`_ below. + For the purposes of import order, OpenStack projects other than the + one to which the file belongs are considered "third party". Only + imports from the same Git repo are considered "project imports" (*) exceptions are: