From 7868295f9b9c8483bedb3731de46cd33f6451c64 Mon Sep 17 00:00:00 2001 From: Artom Lifshitz Date: Mon, 20 Feb 2023 13:45:15 -0500 Subject: [PATCH] Fix nova integration job Running it turned up a bunch of false positives around delayed LOG string interpolation, so we need to fix our pattern match from `.format` to `.format(` to avoid incorrectly catching things like `.format_message()`. We also add the E checks in the Nova integration tests. As we saw in the previous commit, sometimes flake8 gets bugs that caused things that would normally get flagged to not actually get flagged, like lines longer than 80 chars in docstrings. By running Nova integration with E, we make sure any such changes are caught ahead of time. Depends-on: https://review.opendev.org/c/openstack/nova/+/874517 Change-Id: I236a25e5380b5492009d587e76347e52ec50c09f --- .zuul.yaml | 2 +- integration-test/test.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.zuul.yaml b/.zuul.yaml index 5e09d410..53cf072a 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -18,4 +18,4 @@ - openstack/nova vars: tox_envlist: integration - tox_extra_args: -vv openstack nova {{ ansible_user_dir }}/{{ zuul.projects['opendev.org/openstack/nova'].src_dir }} + tox_extra_args: -- openstack nova {{ ansible_user_dir }}/{{ zuul.projects['opendev.org/openstack/nova'].src_dir }} diff --git a/integration-test/test.sh b/integration-test/test.sh index a18faf02..7fb8a09f 100755 --- a/integration-test/test.sh +++ b/integration-test/test.sh @@ -47,7 +47,7 @@ pip install . # Reinstall hacking, the above might have uninstalled it pip install $HACKING -flake8 --select H --statistics +flake8 --select E,H --statistics RET=$? popd