From 59bf3567b004fd007ea9db75a6458c7ad683a514 Mon Sep 17 00:00:00 2001 From: Kui Shi Date: Wed, 21 Aug 2013 09:55:19 +0800 Subject: [PATCH] Improve H202 to cover more cases H202 should cover both of following cases: self.assertRaises(Exception) self.assertRaises(Exception, foo) Change to regex to match both cases. Bug #1214629 Change-Id: I73ac39765b6274f6df9d5251175d9386effae71c --- hacking/core.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hacking/core.py b/hacking/core.py index 1db7f4b6..20772d67 100755 --- a/hacking/core.py +++ b/hacking/core.py @@ -253,8 +253,9 @@ def hacking_except_format_assert(logical_line): Okay: self.assertRaises(NovaException, foo) Okay: self.assertRaises(ExceptionStrangeNotation, foo) H202: self.assertRaises(Exception, foo) + H202: self.assertRaises(Exception) """ - if logical_line.startswith("self.assertRaises(Exception,"): + if re.match(r"self\.assertRaises\(Exception[,\)]", logical_line): yield 1, "H202: assertRaises Exception too broad"