openstack/hacking
Code Issues Proposed changes

Merge "Add assertNotEquals check to H602"

Browse Source
This commit is contained in:
Jenkins 2013-10-15 10:35:39 +00:00 committed by Gerrit Code Review
commit cd31f92ba7
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hacking/core.py
View File

@ -673,18 +673,20 @@ def hacking_no_cr(physical_line):
@flake8ext @flake8ext
def hacking_no_assert_equals(logical_line, tokens): def hacking_no_assert_equals(logical_line, tokens):
r"""assertEquals() is deprecated, use assertEqual instead. r"""assert(Not)Equals() is deprecated, use assert(Not)Equal instead.
Okay: self.assertEqual(0, 0) Okay: self.assertEqual(0, 0)
Okay: self.assertNotEqual(0, 1)
H602: self.assertEquals(0, 0) H602: self.assertEquals(0, 0)
H602: self.assertNotEquals(0, 1)
""" """
for token_type, text, start_index, _, _ in tokens: for token_type, text, start_index, _, _ in tokens:
if token_type == tokenize.NAME and text == "assertEquals": if token_type == tokenize.NAME:
yield ( if text == "assertEquals" or text == "assertNotEquals":
start_index[1], yield (start_index[1],
"H602: assertEquals is deprecated, use assertEqual") "H602: %s is deprecated, use %s" % (text, text[:-1]))
@flake8ext @flake8ext