91 lines
3.0 KiB
Plaintext
91 lines
3.0 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "8d1d6839_d80f6cab",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 30073
|
|
},
|
|
"writtenOn": "2022-06-07T09:31:52Z",
|
|
"side": 1,
|
|
"message": "If this is no longer valid, can we just remove the entire section? Is there a reason it needs to be commented out instead of removed?",
|
|
"revId": "efef85fe4d47122cb31382b9e7cef1ab08738c6d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ee5c101f_01146450",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2022-06-07T14:54:17Z",
|
|
"side": 1,
|
|
"message": "We\u0027d be able to remove it but the commented line exists in the other projects so I followed that.\n\neg.\nhttps://github.com/openstack/heat/blob/f4a25ef09394ac9d820fd91882b240cbb03d1cee/doc/source/conf.py#L137\nhttps://github.com/openstack/cinder/blob/895f3ce283908d867c43204735e96287c186ce69/doc/source/conf.py#L101",
|
|
"parentUuid": "8d1d6839_d80f6cab",
|
|
"revId": "efef85fe4d47122cb31382b9e7cef1ab08738c6d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d53d56d0_7db0b697",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 33493
|
|
},
|
|
"writtenOn": "2022-06-08T01:50:59Z",
|
|
"side": 1,
|
|
"message": "we can set default value ,for example language \u003d en",
|
|
"revId": "efef85fe4d47122cb31382b9e7cef1ab08738c6d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "0145c931_c4c53a7a",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2022-06-08T01:53:28Z",
|
|
"side": 1,
|
|
"message": "Unless language is set, Sphinkx uses en which is the current default, so I don\u0027t think we need to set the default explicitly.\n\nThe main point here is that adding \"language\u003dNone\" is causing an additional warning.",
|
|
"parentUuid": "d53d56d0_7db0b697",
|
|
"revId": "efef85fe4d47122cb31382b9e7cef1ab08738c6d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "173918c6_e73833e7",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9816
|
|
},
|
|
"writtenOn": "2022-07-18T05:50:27Z",
|
|
"side": 1,
|
|
"message": "This is known to break doc build with Sphinx \u003e\u003d 5.0.0 so we better merge this before that version is pulled.",
|
|
"revId": "efef85fe4d47122cb31382b9e7cef1ab08738c6d",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |