Update patch set 2
Patch Set 2: (1 comment) Thanks Vishal for your feedback. I agree to replace v2 by v3 but have one question regarding the volume data we use. Patch-set: 2
This commit is contained in:
parent
d6fec7e621
commit
7bc2698b98
|
@ -22,6 +22,30 @@
|
|||
"revId": "b0f1556d196cecc6a0b6c3887e0a3d346690f275",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "40dd8d2b_dd9476ef",
|
||||
"filename": "heat_dashboard/test/test_data/cinder_data.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 132,
|
||||
"author": {
|
||||
"id": 9816
|
||||
},
|
||||
"writtenOn": "2021-07-28T08:27:41Z",
|
||||
"side": 0,
|
||||
"message": "I\u0027m wondering why we are testing cinder v1 and v2 here though v1 was removed long ago and v2 is being removed now.\nI now understand just removing this is incomplete but I feel like we should replace all examples to test only v3 examples.",
|
||||
"parentUuid": "b41a7137_8e53ba45",
|
||||
"range": {
|
||||
"startLine": 117,
|
||||
"startChar": 4,
|
||||
"endLine": 132,
|
||||
"endChar": 57
|
||||
},
|
||||
"revId": "b0f1556d196cecc6a0b6c3887e0a3d346690f275",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue