Update patch set 2
Patch Set 2: Code-Review-1 (4 comments) thanks for the patch, please find some comments inline. Patch-set: 2 Reviewer: Gerrit User 29313 <29313@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
e6179a0e4b
commit
d6fec7e621
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "b41a7137_8e53ba45",
|
||||
"filename": "heat_dashboard/test/test_data/cinder_data.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 132,
|
||||
"author": {
|
||||
"id": 29313
|
||||
},
|
||||
"writtenOn": "2021-07-28T07:56:58Z",
|
||||
"side": 0,
|
||||
"message": "IMO it is better to use v3 here, you can just replace v2-\u003ev3",
|
||||
"range": {
|
||||
"startLine": 117,
|
||||
"startChar": 4,
|
||||
"endLine": 132,
|
||||
"endChar": 57
|
||||
},
|
||||
"revId": "b0f1556d196cecc6a0b6c3887e0a3d346690f275",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
|
@ -0,0 +1,73 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "abdfb9ee_a235e658",
|
||||
"filename": "heat_dashboard/test/test_data/cinder_data.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 129,
|
||||
"author": {
|
||||
"id": 29313
|
||||
},
|
||||
"writtenOn": "2021-07-28T07:56:58Z",
|
||||
"side": 1,
|
||||
"message": "Could you change it as well v2-\u003ev3?",
|
||||
"range": {
|
||||
"startLine": 129,
|
||||
"startChar": 25,
|
||||
"endLine": 129,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "f0402227628826cd702c87628f3b0f0617347650",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "444fade4_fb291e35",
|
||||
"filename": "heat_dashboard/test/test_data/cinder_data.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 137,
|
||||
"author": {
|
||||
"id": 29313
|
||||
},
|
||||
"writtenOn": "2021-07-28T07:56:58Z",
|
||||
"side": 1,
|
||||
"message": "ditto",
|
||||
"range": {
|
||||
"startLine": 137,
|
||||
"startChar": 25,
|
||||
"endLine": 137,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "f0402227628826cd702c87628f3b0f0617347650",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3567df89_038bd43a",
|
||||
"filename": "heat_dashboard/test/test_data/cinder_data.py",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 145,
|
||||
"author": {
|
||||
"id": 29313
|
||||
},
|
||||
"writtenOn": "2021-07-28T07:56:58Z",
|
||||
"side": 1,
|
||||
"message": "ditto",
|
||||
"range": {
|
||||
"startLine": 145,
|
||||
"startChar": 25,
|
||||
"endLine": 145,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "f0402227628826cd702c87628f3b0f0617347650",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue