Merge "Enable H201: do not write "except:""
This commit is contained in:
commit
dac0629c97
|
@ -22,7 +22,7 @@ class Stack(object):
|
|||
def d3_data(request, stack_id=''):
|
||||
try:
|
||||
stack = stack_get(request, stack_id)
|
||||
except:
|
||||
except Exception:
|
||||
stack = Stack()
|
||||
stack.id = stack_id
|
||||
stack.stack_name = request.session.get('stack_name', '')
|
||||
|
@ -31,7 +31,7 @@ def d3_data(request, stack_id=''):
|
|||
|
||||
try:
|
||||
resources = resources_list(request, stack.stack_name)
|
||||
except:
|
||||
except Exception:
|
||||
resources = []
|
||||
|
||||
d3_data = {"nodes": [], "stack": {}}
|
||||
|
|
|
@ -74,7 +74,7 @@ class StackEventsTab(tabs.Tab):
|
|||
stack_identifier = '%s/%s' % (stack.stack_name, stack.id)
|
||||
events = api.heat.events_list(self.request, stack_identifier)
|
||||
LOG.debug('got events %s' % events)
|
||||
except:
|
||||
except Exception:
|
||||
events = []
|
||||
messages.error(request, _(
|
||||
'Unable to get events for stack "%s".') % stack.stack_name)
|
||||
|
@ -94,7 +94,7 @@ class StackResourcesTab(tabs.Tab):
|
|||
stack_identifier = '%s/%s' % (stack.stack_name, stack.id)
|
||||
resources = api.heat.resources_list(self.request, stack_identifier)
|
||||
LOG.debug('got resources %s' % resources)
|
||||
except:
|
||||
except Exception:
|
||||
resources = []
|
||||
messages.error(request, _(
|
||||
'Unable to get resources for stack "%s".') % stack.stack_name)
|
||||
|
|
|
@ -48,7 +48,7 @@ class IndexView(tables.DataTableView):
|
|||
request = self.request
|
||||
try:
|
||||
stacks = api.heat.stacks_list(self.request)
|
||||
except:
|
||||
except Exception:
|
||||
exceptions.handle(request, _('Unable to retrieve stack list.'))
|
||||
stacks = []
|
||||
return stacks
|
||||
|
@ -107,7 +107,7 @@ class DetailView(tabs.TabView):
|
|||
self._stack = stack
|
||||
request.session['stack_id'] = stack.id
|
||||
request.session['stack_name'] = stack.stack_name
|
||||
except:
|
||||
except Exception:
|
||||
msg = _("Unable to retrieve stack.")
|
||||
redirect = reverse('horizon:project:stacks:index')
|
||||
exceptions.handle(request, msg, redirect=redirect)
|
||||
|
@ -136,7 +136,7 @@ class ResourceView(tabs.TabView):
|
|||
kwargs['stack_id'],
|
||||
kwargs['resource_name'])
|
||||
self._resource = resource
|
||||
except:
|
||||
except Exception:
|
||||
msg = _("Unable to retrieve resource.")
|
||||
redirect = reverse('horizon:project:stacks:index')
|
||||
exceptions.handle(request, msg, redirect=redirect)
|
||||
|
@ -150,7 +150,7 @@ class ResourceView(tabs.TabView):
|
|||
kwargs['stack_id'],
|
||||
kwargs['resource_name'])
|
||||
self._metadata = json.dumps(metadata, indent=2)
|
||||
except:
|
||||
except Exception:
|
||||
msg = _("Unable to retrieve metadata.")
|
||||
redirect = reverse('horizon:project:stacks:index')
|
||||
exceptions.handle(request, msg, redirect=redirect)
|
||||
|
|
3
tox.ini
3
tox.ini
|
@ -39,9 +39,8 @@ exclude = .venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,p
|
|||
# F403 'from <smth> import *' used; unable to detect undefined names
|
||||
# F999 syntax error in doctest
|
||||
# H102 Apache 2.0 license header not found
|
||||
# H201 no 'except:' at least use 'except Exception:'
|
||||
# H302 import only modules.'from optparse import make_option' does not import a module
|
||||
# H4xx docstrings
|
||||
# H701 empty localization string
|
||||
# H702 Formatting operation should be outside of localization method call
|
||||
ignore = E121,E126,E127,E128,F403,F999,H102,H201,H302,H4,H701,H702
|
||||
ignore = E121,E126,E127,E128,F403,F999,H102,H302,H4,H701,H702
|
||||
|
|
Loading…
Reference in New Issue