Update patch set 1

Patch-set: 1
This commit is contained in:
Gerrit User 4257 2018-06-28 17:47:30 +00:00 committed by Gerrit Code Review
parent 38521531c9
commit 59a65a9c64
1 changed files with 42 additions and 0 deletions

View File

@ -430,6 +430,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_ad37d14b",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 1
},
"lineNbr": 92,
"author": {
"id": 4257
},
"writtenOn": "2018-06-28T17:47:30Z",
"side": 1,
"message": "\u003e the ID is stored in properties for resource, which will not pass\n \u003e around when we try to delete the stack.\n\nThe properties are absolutely available at deletion time (see e.g. SoftwareDeployment resources with action\u003dDELETE).\n\nWhat might not work is translations when the underlying secret has been deleted. But we can\u0027t delete the remote stack if the secret has been deleted anyway.\n\nFinally, we have the ResourceData table for storing this kind of thing already and there\u0027s no need to add a separate table to store this one bit of data.",
"parentUuid": "5f7c97a3_496c039d",
"range": {
"startLine": 92,
"startChar": 0,
"endLine": 92,
"endChar": 25
},
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_8fe9c91a",
@ -782,6 +806,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_ed0e298b",
"filename": "specs/rocky/multi-cloud-support.rst",
"patchSetId": 1
},
"lineNbr": 137,
"author": {
"id": 4257
},
"writtenOn": "2018-06-28T17:47:30Z",
"side": 1,
"message": "stack ID is stored in resource_id. Credential could be stored in ResourceData if it weren\u0027t already in ResourcePropertiesData, although it is.",
"parentUuid": "5f7c97a3_89e77be4",
"revId": "681696cee79dfecbf9754ab466c0222ea59f1d2b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5f7c97a3_b8965549",