Update patch set 1
Patch Set 1: Code-Review+1 (3 comments) Patch-set: 1 Label: Code-Review=+1
This commit is contained in:
parent
dd9be368f3
commit
5a9f6acb08
|
@ -0,0 +1,67 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_0e76a8a4",
|
||||
"filename": "specs/rocky/vitrage-resources.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 58,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-07-03T14:58:59Z",
|
||||
"side": 1,
|
||||
"message": "same here",
|
||||
"range": {
|
||||
"startLine": 58,
|
||||
"startChar": 9,
|
||||
"endLine": 58,
|
||||
"endChar": 25
|
||||
},
|
||||
"revId": "7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_fb753001",
|
||||
"filename": "specs/rocky/vitrage-resources.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 84,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-07-03T14:58:59Z",
|
||||
"side": 1,
|
||||
"message": "Not in proposed property, do you mean to add this? If we really need this I think we can use `stack` and allow name or ID as input. Heat can translate it to ID before parsing it down to Vitrage:)",
|
||||
"range": {
|
||||
"startLine": 84,
|
||||
"startChar": 10,
|
||||
"endLine": 84,
|
||||
"endChar": 46
|
||||
},
|
||||
"revId": "7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5f7c97a3_0e84685c",
|
||||
"filename": "specs/rocky/vitrage-resources.rst",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 128,
|
||||
"author": {
|
||||
"id": 12404
|
||||
},
|
||||
"writtenOn": "2018-07-03T14:58:59Z",
|
||||
"side": 1,
|
||||
"message": "We also need a Vitrage client plugin in heat\nlike https://github.com/openstack/heat/commit/d0787393ce1ba073a317c3dccff8251068a707ac#diff-61f981252762ef354a4398789b86e830",
|
||||
"revId": "7888aecf10cf6a2d0f76d0f8532e6b49114ad4ff",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue