openstack/heat-specs
Code Issues Proposed changes

Update patch set 18

Browse Source 
Patch Set 18: Code-Review+1

(4 comments)

Patch-set: 18
Reviewer: Gerrit User 8833 <8833@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 8833 2017-04-21 08:52:35 +00:00 committed by Gerrit Code Review
parent 84873ee33d
commit 7a6b6d2aab
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
707aff8eb0cf601ab39a9bd707d6e9df37c2b705 Normal file
View File

@ -0,0 +1,90 @@
{
"comments": [
{
"key": {
"uuid": "7ffa3b31_0631825a",
"filename": "specs/pike/freezer_resource.rst",
"patchSetId": 18
},
"lineNbr": 49,
"author": {
"id": 8833
},
"writtenOn": "2017-04-21T08:52:35Z",
"side": 1,
"message": "Seems there is a single action API for all actions. If we want to split them based on action types(backup, restore, admin) should not there be one OS::Freezer::RestoreAction too?",
"range": {
"startLine": 48,
"startChar": 0,
"endLine": 49,
"endChar": 26
},
"revId": "707aff8eb0cf601ab39a9bd707d6e9df37c2b705",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_e9a9c98f",
"filename": "specs/pike/freezer_resource.rst",
"patchSetId": 18
},
"lineNbr": 180,
"author": {
"id": 8833
},
"writtenOn": "2017-04-21T08:52:35Z",
"side": 1,
"message": "You need to add a freezerclient plugin too.",
"revId": "707aff8eb0cf601ab39a9bd707d6e9df37c2b705",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_06c4e2f3",
"filename": "specs/pike/freezer_resource.rst",
"patchSetId": 18
},
"lineNbr": 181,
"author": {
"id": 8833
},
"writtenOn": "2017-04-21T08:52:35Z",
"side": 1,
"message": "RestoreAction is mentioned here. Is there any advantage of having a resource for every action type?",
"range": {
"startLine": 181,
"startChar": 38,
"endLine": 181,
"endChar": 51
},
"revId": "707aff8eb0cf601ab39a9bd707d6e9df37c2b705",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7ffa3b31_a9e981e6",
"filename": "specs/pike/freezer_resource.rst",
"patchSetId": 18
},
"lineNbr": 181,
"author": {
"id": 8833
},
"writtenOn": "2017-04-21T08:52:35Z",
"side": 1,
"message": "I think these can be used for server/volume/(db/file) backups. So, this text can be removed.",
"range": {
"startLine": 181,
"startChar": 6,
"endLine": 181,
"endChar": 23
},
"revId": "707aff8eb0cf601ab39a9bd707d6e9df37c2b705",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}