From afe005bce1bc5db9357c1f84f51302e3f907388a Mon Sep 17 00:00:00 2001 From: Gerrit User 4257 <4257@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Thu, 20 May 2021 15:08:55 +0000 Subject: [PATCH] Update patch set 2 Patch Set 2: (3 comments) Patch-set: 2 CC: Gerrit User 4257 <4257@4a232e18-c5a9-48ee-94c0-e04e7cca6543> --- 4dfd64a7d23f6cadf9237c6032ca4e804da854fb | 55 ++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 4dfd64a7d23f6cadf9237c6032ca4e804da854fb diff --git a/4dfd64a7d23f6cadf9237c6032ca4e804da854fb b/4dfd64a7d23f6cadf9237c6032ca4e804da854fb new file mode 100644 index 00000000..1d28d3c9 --- /dev/null +++ b/4dfd64a7d23f6cadf9237c6032ca4e804da854fb @@ -0,0 +1,55 @@ +{ + "comments": [ + { + "key": { + "uuid": "97a2ba6d_43c31308", + "filename": ".gitignore", + "patchSetId": 2 + }, + "lineNbr": 17, + "author": { + "id": 4257 + }, + "writtenOn": "2021-05-20T15:08:55Z", + "side": 1, + "message": "What even is this?\n.gitignore files should only contain stuff that is generated by tools run from within the repo.", + "revId": "4dfd64a7d23f6cadf9237c6032ca4e804da854fb", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + }, + { + "key": { + "uuid": "0a7a9f09_7ebba82e", + "filename": ".gitignore", + "patchSetId": 2 + }, + "lineNbr": 30, + "author": { + "id": 4257 + }, + "writtenOn": "2021-05-20T15:08:55Z", + "side": 1, + "message": "ditto. Everyone uses different tools, so let them set up their own global gitignore rules.", + "revId": "4dfd64a7d23f6cadf9237c6032ca4e804da854fb", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + }, + { + "key": { + "uuid": "0c5e8a60_2b55e0c9", + "filename": ".zuul.yaml", + "patchSetId": 2 + }, + "lineNbr": 4, + "author": { + "id": 4257 + }, + "writtenOn": "2021-05-20T15:08:55Z", + "side": 1, + "message": "I don\u0027t see the point of this. This is a documentation repo. The tests that exist are here to verify the documentation. We don\u0027t care about the coverage of the tests.", + "revId": "4dfd64a7d23f6cadf9237c6032ca4e804da854fb", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": true + } + ] +} \ No newline at end of file