From caadf5c1514259178f3bd88c0ba0dfcd6ebe9c44 Mon Sep 17 00:00:00 2001 From: Gerrit User 4257 <4257@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 4 Jan 2019 01:15:03 +0000 Subject: [PATCH] Update patch set 5 Patch Set 5: Code-Review+1 (1 comment) Cool, this all seems reasonable. Patch-set: 5 Reviewer: Gerrit User 4257 <4257@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=+1 --- f91c7b237196ba25042d5b5e0d0284ba282dfe0d | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 f91c7b237196ba25042d5b5e0d0284ba282dfe0d diff --git a/f91c7b237196ba25042d5b5e0d0284ba282dfe0d b/f91c7b237196ba25042d5b5e0d0284ba282dfe0d new file mode 100644 index 00000000..bf8e2fa5 --- /dev/null +++ b/f91c7b237196ba25042d5b5e0d0284ba282dfe0d @@ -0,0 +1,21 @@ +{ + "comments": [ + { + "key": { + "uuid": "ffd0ebdf_158860c4", + "filename": "specs/stein/vitrage-resources.rst", + "patchSetId": 5 + }, + "lineNbr": 64, + "author": { + "id": 4257 + }, + "writtenOn": "2019-01-04T01:15:03Z", + "side": 1, + "message": "description probably makes more sense as a top-level property.\n\nIt occurs to me that in Heat we actually have a \u0027description\u0027 at the top level of a resource (i.e. the same level as \u0027type\u0027 and \u0027properties\u0027), and that we should probably actually pass _that_ as the description for underlying resources that have one. No resource type has ever implemented that though.", + "revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file