bc732d5025
Patch Set 17: Code-Review-1 (8 comments) Patch-set: 17 Label: Code-Review=-1
208 lines
5.6 KiB
Plaintext
208 lines
5.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_e220feae",
|
|
"filename": "/COMMIT_MSG",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 13,
|
|
"author": {
|
|
"id": 4257
|
|
},
|
|
"writtenOn": "2017-04-19T16:15:05Z",
|
|
"side": 1,
|
|
"message": "Don\u0027t use Signed-off-by in OpenStack. You probably want Co-authored-by here.",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_c243c26b",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 44,
|
|
"author": {
|
|
"id": 12404
|
|
},
|
|
"writtenOn": "2017-04-19T16:33:42Z",
|
|
"side": 1,
|
|
"message": "I think we should add Freezer client as well",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_3dd84b1c",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 46,
|
|
"author": {
|
|
"id": 12404
|
|
},
|
|
"writtenOn": "2017-04-19T16:33:42Z",
|
|
"side": 1,
|
|
"message": "What about `v1/sessions`?",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_bda8db8b",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 71,
|
|
"author": {
|
|
"id": 12404
|
|
},
|
|
"writtenOn": "2017-04-19T16:33:42Z",
|
|
"side": 1,
|
|
"message": "maybe just `volume` in implement and use heat translate",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_421fb2b6",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 86,
|
|
"author": {
|
|
"id": 4257
|
|
},
|
|
"writtenOn": "2017-04-19T16:15:05Z",
|
|
"side": 1,
|
|
"message": "resources",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_02640a49",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 90,
|
|
"author": {
|
|
"id": 4257
|
|
},
|
|
"writtenOn": "2017-04-19T16:15:05Z",
|
|
"side": 1,
|
|
"message": "I hope this is optional",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_7d6ed32f",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 94,
|
|
"author": {
|
|
"id": 12404
|
|
},
|
|
"writtenOn": "2017-04-19T16:33:42Z",
|
|
"side": 1,
|
|
"message": "same here",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_e268fe1d",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 98,
|
|
"author": {
|
|
"id": 4257
|
|
},
|
|
"writtenOn": "2017-04-19T16:15:05Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_bd59fb8e",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 103,
|
|
"author": {
|
|
"id": 12404
|
|
},
|
|
"writtenOn": "2017-04-19T16:33:42Z",
|
|
"side": 1,
|
|
"message": "same here (use heat translate)",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_7d57f359",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 116,
|
|
"author": {
|
|
"id": 12404
|
|
},
|
|
"writtenOn": "2017-04-19T16:33:42Z",
|
|
"side": 1,
|
|
"message": "ditto",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_3d33abf8",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 171,
|
|
"author": {
|
|
"id": 12404
|
|
},
|
|
"writtenOn": "2017-04-19T16:33:42Z",
|
|
"side": 1,
|
|
"message": "Just try to be clear, so you not going to implement this?",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7ffa3b31_7d425340",
|
|
"filename": "specs/pike/freezer_resource.rst",
|
|
"patchSetId": 17
|
|
},
|
|
"lineNbr": 175,
|
|
"author": {
|
|
"id": 12404
|
|
},
|
|
"writtenOn": "2017-04-19T16:33:42Z",
|
|
"side": 1,
|
|
"message": "please at least target pike-2",
|
|
"revId": "f9865530d00040f37ec3c6def112edd69b79681c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |