heat-specs/5a7ea18ca171b1be20648d3fac640b67dc02fb96
Gerrit User 8289 c2f38cea9d Update patch set 3
Patch Set 3:

(1 comment)

Patch-set: 3
2017-03-03 03:15:51 +00:00

127 lines
4.3 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "da36d5c6_a793624e",
"filename": "specs/newton/support-glance-image-member.rst",
"patchSetId": 3
},
"lineNbr": 37,
"author": {
"id": 12404
},
"writtenOn": "2017-02-22T06:10:43Z",
"side": 1,
"message": "Potentially this could also be a list properties in Image resource",
"revId": "5a7ea18ca171b1be20648d3fac640b67dc02fb96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_c2a11948",
"filename": "specs/newton/support-glance-image-member.rst",
"patchSetId": 3
},
"lineNbr": 54,
"author": {
"id": 9542
},
"writtenOn": "2016-06-13T14:00:48Z",
"side": 1,
"message": "according to docs [0] this is supported only since v2.1 api (and fully only since v2.2).\n\nHow are we going to differentiate those from v2.0?",
"revId": "5a7ea18ca171b1be20648d3fac640b67dc02fb96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_e9e41cad",
"filename": "specs/newton/support-glance-image-member.rst",
"patchSetId": 3
},
"lineNbr": 54,
"author": {
"id": 8289
},
"writtenOn": "2016-06-17T08:40:25Z",
"side": 1,
"message": "Would you please give the doc link?",
"parentUuid": "7aa08908_c2a11948",
"revId": "5a7ea18ca171b1be20648d3fac640b67dc02fb96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa31d9ce_1c647020",
"filename": "specs/newton/support-glance-image-member.rst",
"patchSetId": 3
},
"lineNbr": 54,
"author": {
"id": 9542
},
"writtenOn": "2017-02-13T17:59:21Z",
"side": 1,
"message": "I can swear I saw it, but can\u0027t find it anymore. Besides now Glance docs say that memberships were supported in v1 too...\n\n/me is very puzzled",
"parentUuid": "7aa08908_e9e41cad",
"revId": "5a7ea18ca171b1be20648d3fac640b67dc02fb96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da36d5c6_c7e856b7",
"filename": "specs/newton/support-glance-image-member.rst",
"patchSetId": 3
},
"lineNbr": 54,
"author": {
"id": 12404
},
"writtenOn": "2017-02-22T06:10:43Z",
"side": 1,
"message": "Now the Glance V2 as default version already landed, if like what Pavlo said, we should be fine even user turn to V1 as client version",
"parentUuid": "fa31d9ce_1c647020",
"revId": "5a7ea18ca171b1be20648d3fac640b67dc02fb96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba2be162_1740eca4",
"filename": "specs/newton/support-glance-image-member.rst",
"patchSetId": 3
},
"lineNbr": 54,
"author": {
"id": 8289
},
"writtenOn": "2017-03-03T03:15:51Z",
"side": 1,
"message": "IIUC, the memberships are supported both in v1 and v2, but there is different between v1 and v2:\nv1: \nafter the member create, the specified tenant can use \nthe image directly, and also if \u0027can_share\u0027 flag is set, it allows the specified tenant to share the image.\n\nv2:\nthe specified tenant can use the image if he/she accept the membership. And he/she can\u0027t share the image to other tenants.",
"parentUuid": "da36d5c6_c7e856b7",
"revId": "5a7ea18ca171b1be20648d3fac640b67dc02fb96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da36d5c6_27ce925a",
"filename": "specs/newton/support-glance-image-member.rst",
"patchSetId": 3
},
"lineNbr": 74,
"author": {
"id": 12404
},
"writtenOn": "2017-02-22T06:10:43Z",
"side": 1,
"message": "Please kindly change the version",
"revId": "5a7ea18ca171b1be20648d3fac640b67dc02fb96",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}