openstack/heat-specs
Code Issues Proposed changes
a18da14416
heat-specs/f91c7b237196ba25042d5b5e0d0284ba282dfe0d
Gerrit User 19159 c656994365 Update patch set 5 
Patch-set: 5
2019-02-20 17:44:09 +00:00

194 lines
7.6 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "ffd0ebdf_158860c4",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 64,
"author": {
"id": 4257
},
"writtenOn": "2019-01-04T01:15:03Z",
"side": 1,
"message": "description probably makes more sense as a top-level property.\n\nIt occurs to me that in Heat we actually have a \u0027description\u0027 at the top level of a resource (i.e. the same level as \u0027type\u0027 and \u0027properties\u0027), and that we should probably actually pass _that_ as the description for underlying resources that have one. No resource type has ever implemented that though.",
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ffd0ebdf_1b45eeb3",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 64,
"author": {
"id": 4257
},
"writtenOn": "2019-01-04T08:55:52Z",
"side": 1,
"message": "I implemented this: I56560d014a02b5f2ddbc08689d39147fbe4ffca4",
"parentUuid": "ffd0ebdf_158860c4",
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ffd0ebdf_c719cb88",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 64,
"author": {
"id": 12404
},
"writtenOn": "2019-01-04T09:03:06Z",
"side": 1,
"message": "+1",
"parentUuid": "ffd0ebdf_158860c4",
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfd5e7cf_ab06e51f",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 64,
"author": {
"id": 19159
},
"writtenOn": "2019-01-06T09:42:33Z",
"side": 1,
"message": "Done",
"parentUuid": "ffd0ebdf_c719cb88",
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ffd0ebdf_cae8f217",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 97,
"author": {
"id": 12404
},
"writtenOn": "2019-01-04T09:03:06Z",
"side": 1,
"message": "we should directly use `heat_stack` here and translate it to id internally in our Vitrage resource implementation in Heat. Which will allow user to give either id or name for a stack. and Vitrage will only get ID of the stack.\nSee [1] and [2] for example\n\n[1] https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/magnum/cluster.py#L176\n[2] https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/magnum/cluster.py#L131",
"range": {
"startLine": 97,
"startChar": 11,
"endLine": 97,
"endChar": 24
},
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfd5e7cf_e63f44b3",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 97,
"author": {
"id": 19159
},
"writtenOn": "2019-01-06T09:42:33Z",
"side": 1,
"message": "Sorry, I didn\u0027t quite understand your comment. Are you saying that the user can write either:\n\nheat_stack: {get_param: \"OS::stack_id\"}\n\nOr:\n\nheat_stack: {\"MyStack1\"}\n\nAnd then Vitrage resource should automatically figure out the stack id? \n\n\nI\u0027m not sure how we can make it work, since in this example heat_stack_id is simply a parameter that Vitrage passes to Mistral workflow when it executes it. It could be any other parameter and it could be called by any other name. Vitrage does not understand the meaning of the parameters, it simply injects them into the right places in the template.",
"parentUuid": "ffd0ebdf_cae8f217",
"range": {
"startLine": 97,
"startChar": 11,
"endLine": 97,
"endChar": 24
},
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfd5e7cf_ea7842f9",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 97,
"author": {
"id": 12404
},
"writtenOn": "2019-01-08T15:04:49Z",
"side": 1,
"message": "\u003e Sorry, I didn\u0027t quite understand your comment. Are you saying that\n \u003e the user can write either:\n \u003e \n \u003e heat_stack: {get_param: \"OS::stack_id\"}\n \u003e \n \u003e Or:\n \u003e \n \u003e heat_stack: {\"MyStack1\"}\n \u003e \n \u003e And then Vitrage resource should automatically figure out the stack\n \u003e id?\n\nI\u0027m saying heat already got implementation to translate either name or ID to ID, so we allow\nheat_stack: {get_param: \"OS::stack_id\"}\nOr:\nheat_stack: {\"MyStack1\"}\nhere, but the value of heat_stack will auto translate and change to ID for the value to. So when user put `heat_stack: {\"MyStack1\"}` in hot template, you will get the UUID of MyStack1 when you try to get the property during handling the resource.\nAnd Vitrage needs to do nothing here (And Heat will make sure Vitrage and Mistral always get the ID of that Heat Stack when asking value from that parameter)",
"parentUuid": "dfd5e7cf_e63f44b3",
"range": {
"startLine": 97,
"startChar": 11,
"endLine": 97,
"endChar": 24
},
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dfd5e7cf_f3a911df",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 97,
"author": {
"id": 19159
},
"writtenOn": "2019-01-09T07:42:26Z",
"side": 1,
"message": "Ok. I can change the example.\n\nBTW, I copied the heat_stack reference from here: https://github.com/openstack/heat-templates/blob/master/hot/autohealing/autohealing_server.yaml#L133",
"parentUuid": "dfd5e7cf_ea7842f9",
"range": {
"startLine": 97,
"startChar": 11,
"endLine": 97,
"endChar": 24
},
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fdfeff1_1225b4ab",
"filename": "specs/stein/vitrage-resources.rst",
"patchSetId": 5
},
"lineNbr": 97,
"author": {
"id": 19159
},
"writtenOn": "2019-02-20T17:44:09Z",
"side": 1,
"message": "Well... I tried to use {\"MyStack1\"} and it didn\u0027t work. When I switched back to using {get_param: \"OS:stack_id\") it worked fine. Any idea why?",
"parentUuid": "dfd5e7cf_f3a911df",
"range": {
"startLine": 97,
"startChar": 11,
"endLine": 97,
"endChar": 24
},
"revId": "f91c7b237196ba25042d5b5e0d0284ba282dfe0d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink