heat-specs/5b104c92e9fc3e18623c0d943c54327c879380d5

{
  "comments": [
    {
      "key": {
        "uuid": "5f7c97a3_0d75a500",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 48,
      "author": {
        "id": 4257
      },
      "writtenOn": "2018-06-28T17:47:30Z",
      "side": 1,
      "message": "Trying to figure out what this means. It\u0027s the data like auth_url and stuff for the remote cloud? In what sense is that a credential?",
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f7c97a3_f174bf06",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 48,
      "author": {
        "id": 12404
      },
      "writtenOn": "2018-06-29T06:59:39Z",
      "side": 1,
      "message": "To formalized what we needs from Barbican secret, I adopt same format as credential(credential_secret_id).\nIt will contains auth_type and auth(which contains auth_url)\nIn this sense, I call it with provider credential. Any better name than that?:)\n\nI changed this key to  ``provider_credential_secret_id``",
      "parentUuid": "5f7c97a3_0d75a500",
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f7c97a3_0dc36508",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 60,
      "author": {
        "id": 4257
      },
      "writtenOn": "2018-06-28T17:47:30Z",
      "side": 1,
      "message": "Maybe we should use a name like credential_secret_id (although it would be nice if we allowed name or id to allow for rotation) to make sure that people don\u0027t try to stick their secret inline.",
      "range": {
        "startLine": 60,
        "startChar": 6,
        "endLine": 60,
        "endChar": 16
      },
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f7c97a3_31e0f797",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 60,
      "author": {
        "id": 12404
      },
      "writtenOn": "2018-06-29T06:59:39Z",
      "side": 1,
      "message": "why would people try to directly put secrets on?:)\ncredential_secret_id works for me",
      "parentUuid": "5f7c97a3_0dc36508",
      "range": {
        "startLine": 60,
        "startChar": 6,
        "endLine": 60,
        "endChar": 16
      },
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f7c97a3_8d68d522",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 68,
      "author": {
        "id": 4257
      },
      "writtenOn": "2018-06-28T17:47:30Z",
      "side": 1,
      "message": "Yes, good question :)",
      "range": {
        "startLine": 68,
        "startChar": 0,
        "endLine": 68,
        "endChar": 56
      },
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f7c97a3_0d6cb7ce",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 68,
      "author": {
        "id": 12404
      },
      "writtenOn": "2018-06-29T06:59:39Z",
      "side": 1,
      "message": "removed",
      "parentUuid": "5f7c97a3_8d68d522",
      "range": {
        "startLine": 68,
        "startChar": 0,
        "endLine": 68,
        "endChar": 56
      },
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f7c97a3_0d5e0579",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 70,
      "author": {
        "id": 4257
      },
      "writtenOn": "2018-06-28T17:47:30Z",
      "side": 1,
      "message": "Pretty sure they can, but this sounds like an opportunity to fix it if not.",
      "range": {
        "startLine": 69,
        "startChar": 5,
        "endLine": 70,
        "endChar": 53
      },
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f7c97a3_6da4594c",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 76,
      "author": {
        "id": 4257
      },
      "writtenOn": "2018-06-28T17:47:30Z",
      "side": 1,
      "message": "All that schema stuff is only for convenience anyway. You can always override needs_replace_with_prop_diff and do whatever you need. And if the convenience functions don\u0027t do the right thing, we can fix them. None of this seems like a good reason to go with a bad resource interface.",
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "5f7c97a3_cd655fe4",
        "filename": "specs/rocky/multi-cloud-support.rst",
        "patchSetId": 4
      },
      "lineNbr": 76,
      "author": {
        "id": 12404
      },
      "writtenOn": "2018-06-29T06:59:39Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "5f7c97a3_6da4594c",
      "revId": "5b104c92e9fc3e18623c0d943c54327c879380d5",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}