openstack/heat-templates
Code Issues Proposed changes

Add sudo -E to heat-jeos recommended command

Browse Source 
Normally heat would be run without root capabilities.  The
directory /var/lib/libvirt/images is typically not world
readable.  As a result, the glance operation requires root
permissions to actually read the file, and may be a source
of confusion for users.

Also break the notification into two lines since it wraps on
80 character windows.

Change-Id: I905f3c24ed253ddc1e843bc73c93464c65d3df0b
This commit is contained in:
sdake 2013-06-02 12:02:39 -07:00
parent 5e92be740d
commit 609e9789cf
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/heat-jeos.sh
View File

@ -41,8 +41,9 @@ FMTFILE="${LIBVIRT_IMGDIR}/${TDLNAME}.${DISK_FORMAT}"
qemu-img convert -c -O ${DISK_FORMAT} ${DSKFILE} ${FMTFILE} qemu-img convert -c -O ${DISK_FORMAT} ${DSKFILE} ${FMTFILE}
if [ -f ${FMTFILE} ]; then if [ -f ${FMTFILE} ]; then
echo "Image ${FMTFILE} complete, now add image to glance, e.g:" echo "Image ${FMTFILE} creation complete."
GLANCECMD="glance add name=${TDLNAME} is_public=true disk_format=${DISK_FORMAT} container_format=bare" echo "Add the image to glance with the command:"
GLANCECMD="sudo -E glance add name=${TDLNAME} is_public=true disk_format=${DISK_FORMAT} container_format=bare"
echo "${GLANCECMD} < ${FMTFILE}" echo "${GLANCECMD} < ${FMTFILE}"
else else
echo "Error creating image file ${FMTFILE}" echo "Error creating image file ${FMTFILE}"