openstack
/
heat-translator
Code Issues Proposed changes

Replace assertItemsEqual with assertCountEqual 

assertItemsEqual was removed from Python's unittest.TestCase in
Python 3.3 [1][2]. We have been able to use them since then, because
testtools required unittest2, which still included it. With testtools
removing Python 2.7 support [3][4], we will lose support for
assertItemsEqual, so we should switch to use assertCountEqual.

[1] - https://bugs.python.org/issue17866
[2] - https://hg.python.org/cpython/rev/d9921cb6e3cd
[3] - https://github.com/testing-cabal/testtools/issues/286
[4] - https://github.com/testing-cabal/testtools/pull/277

Change-Id: I53f758e7e8870b43b675f4c63d986f07d199c259
This commit is contained in:
JO Hiroyuki 2020-03-27 23:21:56 +09:00
parent b57e27bd61
commit 0d0b1a1821
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
translator/tests/test_translate_node_template.py
View File

@ -42,4 +42,4 @@ class TranslateNodeTemplatesTest(TestCase):
]
actual_type_list = list(_generate_type_map())
self.assertItemsEqual(expected_type_list, actual_type_list)
self.assertCountEqual(expected_type_list, actual_type_list)