Update patch set 4
Patch Set 4: Code-Review-1 (3 comments) Patch-set: 4 Reviewer: Gerrit User 33455 <33455@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 Attention: {"person_ident":"Gerrit User 33455 \u003c33455@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Hiromu Asahina replied on the change"} Attention: {"person_ident":"Gerrit User 31667 \u003c31667@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Hiromu Asahina replied on the change"}
This commit is contained in:
parent
ff7a19f4c0
commit
bd5177ba09
|
@ -0,0 +1,61 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "0fef97b3_b7247566",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-06-08T09:55:53Z",
|
||||
"side": 1,
|
||||
"message": "Could you add an appropriate reference to explain this change?",
|
||||
"revId": "855777c4949f1e49cd8691387ce56bb4d68ff58b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "d7f07a25_d0ffd4df",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-06-08T09:55:53Z",
|
||||
"side": 1,
|
||||
"message": "Thank you for the patch.\nPlease kindly find my comments.\n\n\u003e Patch Set 4: Code-Review-1\n\u003e \n\u003e Thanks for the patch! Can you please add a test to cover the subnetpool scenario? Something to ensure that the translation occurs properly. Thanks\n\n+1\nAdding a test case to ``test_tosca_hot_translation`` [1] with a new sample file might be better.\n\n[1] https://github.com/openstack/heat-translator/blob/master/translator/tests/test_tosca_hot_translation.py#L483 ",
|
||||
"revId": "855777c4949f1e49cd8691387ce56bb4d68ff58b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "af7f93fd_f12af8ec",
|
||||
"filename": "translator/hot/tosca/tosca_network_network.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 47,
|
||||
"author": {
|
||||
"id": 33455
|
||||
},
|
||||
"writtenOn": "2022-06-08T09:55:53Z",
|
||||
"side": 1,
|
||||
"message": "Please use parentheses instead [1].\n\n[1] https://docs.openstack.org/hacking/latest/user/hacking.html#general\n\n\u003e It is preferred to wrap long lines in parentheses and not a backslash for line continuation.",
|
||||
"range": {
|
||||
"startLine": 47,
|
||||
"startChar": 54,
|
||||
"endLine": 47,
|
||||
"endChar": 56
|
||||
},
|
||||
"revId": "855777c4949f1e49cd8691387ce56bb4d68ff58b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue