openstack
/
heat
Code Issues Proposed changes

Fix restore_prev_rsrc assert weakref 

Currently restore_prev_rsrc is broken in cause of
weakref assertion error - it raises during building
resources for backup stack.

Change-Id: I78f896455f02900389f7c5055264b35f86bb7d18
Closes-bug: #1661259
This commit is contained in:
Peter Razumovsky 2017-02-01 14:28:06 +04:00
parent 8b7691bb8f
commit 01580af10a
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
heat/engine/resources/openstack/neutron/port.py
View File

@ -536,8 +536,9 @@ class Port(neutron.NeutronResource):
def restore_prev_rsrc(self, convergence=False):
# In case of convergence, during rollback, the previous rsrc is
# already selected and is being acted upon.
bakup_resources = self.stack._backup_stack().resources
prev_port = self if convergence else bakup_resources.get(self.name)
backup_stack = self.stack._backup_stack()
backup_res = backup_stack.resources.get(self.name)
prev_port = self if convergence else backup_res
fixed_ips = prev_port.data().get('port_fip', [])
props = {'fixed_ips': []}

3
heat/engine/resources/openstack/nova/server_network_mixin.py
View File

@ -477,7 +477,8 @@ class ServerNetworkMixin(object):
# In case of convergence, during rollback, the previous rsrc is
# already selected and is being acted upon.
backup_res = self.stack._backup_stack().resources.get(self.name)
backup_stack = self.stack._backup_stack()
backup_res = backup_stack.resources.get(self.name)
prev_server = self if convergence else backup_res
if convergence: