openstack/heat
Code Issues Proposed changes

Add 'required' attribute to OS::Heat::CWLiteAlarm properties

Browse Source 
Add 'required=True' relying on 
http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cw-alarm.html
 
Change-Id: I524729c084db9976fcefca8d7ebc16abd0c92ffe
Closes-Bug: #1395711
This commit is contained in:
Tetiana Lashchova 2014-11-25 18:44:27 +02:00
parent 9698da6804
commit 095249058f
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
heat/engine/resources/cloud_watch.py
View File

@ -46,6 +46,7 @@ class CloudWatchAlarm(resource.Resource):
'LessThanThreshold',
'LessThanOrEqualToThreshold']),
],
required=True,
update_allowed=True
),
ALARM_DESCRIPTION: properties.Schema(
@ -56,19 +57,23 @@ class CloudWatchAlarm(resource.Resource):
EVALUATION_PERIODS: properties.Schema(
properties.Schema.STRING,
_('Number of periods to evaluate over.'),
required=True,
update_allowed=True
),
METRIC_NAME: properties.Schema(
properties.Schema.STRING,
_('Metric name watched by the alarm.')
_('Metric name watched by the alarm.'),
required=True
),
NAMESPACE: properties.Schema(
properties.Schema.STRING,
_('Namespace for the metric.')
_('Namespace for the metric.'),
required=True
),
PERIOD: properties.Schema(
properties.Schema.STRING,
_('Period (seconds) to evaluate over.'),
required=True,
update_allowed=True
),
STATISTIC: properties.Schema(
@ -78,6 +83,7 @@ class CloudWatchAlarm(resource.Resource):
constraints.AllowedValues(['SampleCount', 'Average', 'Sum',
'Minimum', 'Maximum']),
],
required=True,
update_allowed=True
),
ALARM_ACTIONS: properties.Schema(
@ -104,6 +110,7 @@ class CloudWatchAlarm(resource.Resource):
THRESHOLD: properties.Schema(
properties.Schema.STRING,
_('Threshold to evaluate against.'),
required=True,
update_allowed=True
),
UNITS: properties.Schema(