openstack/heat
Code Issues Proposed changes

Replace assertTrue(isinstance()) with assertIsInstance()

Browse Source 
Some of tests use different method of assertTrue(isinstance(A, B)) or
assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
B) provided by testtools.
There has one more place should be modified.

Change-Id: I751a2fb79857c09952a59e29301bf54ff6482d01
Closes-bug: #1268480
This commit is contained in:
LiuNanke
2016-01-03 03:34:58 +08:00
parent 08154cdd0e
commit 0976a20b41
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
heat_integrationtests/functional/test_resource_chain.py
View File

@@ -83,7 +83,7 @@ class ResourceChainTests(functional_base.FunctionalTestsBase):
resource_attrs = self._stack_output(stack, 'all-resource-attrs')
self.assertTrue(resource_attrs is not None)
self.assertTrue(isinstance(resource_attrs, dict))
self.assertIsInstance(resource_attrs, dict)
self.assertEqual(2, len(resource_attrs))
self.assertEqual(8, len(resource_attrs['0']))
self.assertEqual(8, len(resource_attrs['1']))