Browse Source
Enabled hacking checks to check dict.iteritems, dict.itervalues and dict.iterkeys should not be used in the future and raise error while running pep8 using tox. Change-Id: I1239bb5c651d0193141d5bb830872caf172ec561changes/51/269051/5
3 changed files with 100 additions and 2 deletions
@ -0,0 +1,48 @@
|
||||
# Copyright 2016 NTT DATA. |
||||
# |
||||
# Licensed under the Apache License, Version 2.0 (the "License"); you may |
||||
# not use this file except in compliance with the License. You may obtain |
||||
# a copy of the License at |
||||
# |
||||
# http://www.apache.org/licenses/LICENSE-2.0 |
||||
# |
||||
# Unless required by applicable law or agreed to in writing, software |
||||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT |
||||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the |
||||
# License for the specific language governing permissions and limitations |
||||
# under the License. |
||||
|
||||
from heat.hacking import checks |
||||
from heat.tests import common |
||||
|
||||
|
||||
class HackingTestCase(common.HeatTestCase): |
||||
def test_dict_iteritems(self): |
||||
self.assertEqual(1, len(list(checks.check_python3_no_iteritems( |
||||
"obj.iteritems()")))) |
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_iteritems( |
||||
"obj.items()")))) |
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_iteritems( |
||||
"six.iteritems(ob))")))) |
||||
|
||||
def test_dict_iterkeys(self): |
||||
self.assertEqual(1, len(list(checks.check_python3_no_iterkeys( |
||||
"obj.iterkeys()")))) |
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_iterkeys( |
||||
"obj.keys()")))) |
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_iterkeys( |
||||
"six.iterkeys(ob))")))) |
||||
|
||||
def test_dict_itervalues(self): |
||||
self.assertEqual(1, len(list(checks.check_python3_no_itervalues( |
||||
"obj.itervalues()")))) |
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_itervalues( |
||||
"obj.values()")))) |
||||
|
||||
self.assertEqual(0, len(list(checks.check_python3_no_itervalues( |
||||
"six.itervalues(ob))")))) |
Loading…
Reference in new issue