openstack
/
heat
Code Issues Proposed changes

Enable E251 style check 

unexpected space around 'equals' operator

Change-Id: I8566d918a2abb8cac358832fb5af551fad9b058f
This commit is contained in:
Pavlo Shchelokovskyy 2014-12-14 20:46:29 +02:00
parent f72c3c4843
commit 2e9fcbba64
3 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/rackspace/rackspace/tests/test_cloud_loadbalancer.py
View File

@ -411,8 +411,8 @@ class LoadBalancerTest(common.HeatTestCase):
metadata={'yolo': 'heeyyy_gurl'})
expected = self._set_expected(self.expected_body,
sessionPersistence=
{'persistenceType': 'HTTP_COOKIE'},
sessionPersistence={
'persistenceType': 'HTTP_COOKIE'},
connectionLogging={'enabled': True},
metadata=[
{'key': 'yolo',

18
heat/engine/parameters.py
View File

@ -536,12 +536,12 @@ class Parameters(collections.Mapping):
yield Parameter(self.PARAM_REGION,
Schema(Schema.STRING,
default='ap-southeast-1',
constraints=
[constr.AllowedValues(['us-east-1',
'us-west-1',
'us-west-2',
'sa-east-1',
'eu-west-1',
'ap-southeast-1',
'ap-northeast-1']
)]))
constraints=[
constr.AllowedValues(['us-east-1',
'us-west-1',
'us-west-2',
'sa-east-1',
'eu-west-1',
'ap-southeast-1',
'ap-northeast-1']
)]))

3
tox.ini
View File

@ -52,7 +52,6 @@ commands = python setup.py build_sphinx
commands = oslo-config-generator --config-file=config-generator.conf
[flake8]
# E251 unexpected spaces around keyword / parameter equals
# H202 assertRaises Exception too broad
# H233 Python 3.x incompatible use of print operator
# H305 imports not grouped correctly
@ -62,7 +61,7 @@ commands = oslo-config-generator --config-file=config-generator.conf
# H405 multi line docstring summary not separated with an empty line
# H803 no full stop at the end of the commit message
# H904 Wrap long lines in parentheses instead of a backslash
ignore = E251,H202,H233,H305,H307,H402,H404,H405,H803,H904
ignore = H202,H233,H305,H307,H402,H404,H405,H803,H904
show-source = true
exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,tools,build
max-complexity=20