openstack/heat
Code Issues Proposed changes

autoscaling: don't kill all instances when scaling down

Browse Source 
only delete the difference between the old capacity and the new capacity

doh!

Change-Id: Idbb16b2fa93abcad2793d5b4365c18a01e588b99
Signed-off-by: Angus Salkeld <asalkeld@redhat.com>
This commit is contained in:
Angus Salkeld 2012-07-23 20:12:05 +10:00
parent deebc5c42a
commit 312a84ec70
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
heat/engine/autoscaling.py
View File

@ -101,7 +101,10 @@ class AutoScalingGroup(Resource):
return
if new_capacity == capacity:
logger.debug('no change in capacity %d' % capacity)
return
logger.debug('adjusting capacity from %d to %d' % (capacity,
new_capacity))
conf = self.properties['LaunchConfigurationName']
if new_capacity > capacity:
@ -116,7 +119,7 @@ class AutoScalingGroup(Resource):
inst.create()
else:
# shrink (kill largest numbered first)
del_list = inst_list[:]
del_list = inst_list[new_capacity:]
for victim in reversed(del_list):
inst = instance.Instance(victim,
self.stack.t['Resources'][conf],