openstack/heat
Code Issues Proposed changes

Don't query stack tags twice

Browse Source 
Retrieving the field from the db object triggers the query to
stack_tags, so we don't need to do it a second time to retrieve the list
of tags. Instead, use the data directly.

Change-Id: Ibe6ac45d54afca6588b1b71ffa7278977d2f4d8a
This commit is contained in:
Thomas Herve 2016-02-15 05:53:17 +01:00
parent 681df8eb00
commit 39b772844d
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
heat/objects/stack.py
View File

@ -71,11 +71,8 @@ class Stack(
raw_template.RawTemplate.get_by_id(
context, db_stack['raw_template_id']))
elif field == 'tags':
if db_stack.get(field) is not None:
stack['tags'] = stack_tag.StackTagList.get(
context, db_stack['id'])
else:
stack['tags'] = None
stack['tags'] = stack_tag.StackTagList.from_db_object(
context, db_stack.get(field))
else:
stack[field] = db_stack.__dict__.get(field)
stack._context = context

5
heat/objects/stack_tag.py
View File

@ -80,3 +80,8 @@ class StackTagList(
@classmethod
def delete(cls, context, stack_id):
db_api.stack_tags_delete(context, stack_id)
@classmethod
def from_db_object(cls, context, db_tags):
if db_tags is not None:
return base.obj_make_list(context, cls(), StackTag, db_tags)