openstack
/
heat
Code Issues Proposed changes

Downgrade some exception logs to INFO level 

LOG.exception() logs at ERROR level, but these are not really what an
operator would consider errors.

Change-Id: I91e85fd809cb121fbfa4c583880b050557dc659a
This commit is contained in:
Zane Bitter 2016-06-06 17:06:19 -04:00
parent 0e523401c2
commit 490702f285
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
heat/engine/resource.py
View File

@ -1964,8 +1964,9 @@ class Resource(object):
# Don't log an event as it just spams the user.
pass
except Exception as ex:
LOG.exception(_LE('signal %(name)s : %(msg)s')
% {'name': six.text_type(self), 'msg': ex})
LOG.info(_LI('signal %(name)s : %(msg)s'),
{'name': six.text_type(self), 'msg': ex},
exc_info=True)
failure = exception.ResourceFailure(ex, self)
raise failure

10
heat/engine/stack.py
View File

@ -776,7 +776,7 @@ class Stack(collections.Mapping):
except AssertionError:
raise
except Exception as ex:
LOG.exception(_LE("Exception: %s"), ex)
LOG.info(_LI("Exception in stack validation"), exc_info=True)
raise exception.StackValidationFailed(
message=encodeutils.safe_decode(six.text_type(ex)))
if result:
@ -1853,8 +1853,8 @@ class Stack(collections.Mapping):
scheduler.TaskRunner(res.destroy)()
except exception.ResourceFailure as ex:
failed = True
LOG.error(_LE('Resource %(name)s delete failed: %(ex)s'),
{'name': res.name, 'ex': ex})
LOG.info(_LI('Resource %(name)s delete failed: %(ex)s'),
{'name': res.name, 'ex': ex})
for res in deps:
if not failed:
@ -1862,9 +1862,9 @@ class Stack(collections.Mapping):
res.state_reset()
scheduler.TaskRunner(res.create)()
except exception.ResourceFailure as ex:
LOG.exception(_LE('Resource %(name)s create failed: '
'%(ex)s'), {'name': res.name, 'ex': ex})
failed = True
LOG.info(_LI('Resource %(name)s create failed: '
'%(ex)s'), {'name': res.name, 'ex': ex})
else:
res.state_set(res.CREATE, res.FAILED,
'Resource restart aborted')