openstack
/
heat
Code Issues Proposed changes

test_signal add missing VerifyAll calls 

Some tests set mox into replay mode without then doing VerifyAll so
add where missing.

Change-Id: I230768c1e170ab9fab5ca6131394058c2de019f1
This commit is contained in:
Steven Hardy 2014-02-03 13:49:46 +00:00
parent ad6051ba7c
commit 4d3964a9c2
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
heat/tests/test_signal.py
View File

@ -114,6 +114,7 @@ class SignalTest(HeatTestCase):
rsrc = self.stack['signal_handler']
self.assertEqual((rsrc.CREATE, rsrc.FAILED), rsrc.state)
self.assertIn('Forbidden', rsrc.status_reason)
self.m.VerifyAll()
@utils.stack_delete_after
def test_handle_create_fail_keypair_raise(self):
@ -137,6 +138,7 @@ class SignalTest(HeatTestCase):
self.assertIn('Forbidden', rsrc.status_reason)
self.assertEqual('123xyz', rs_data.get('user_id'))
self.assertIsNone(rsrc.resource_id)
self.m.VerifyAll()
@utils.stack_delete_after
def test_handle_create_fail_keypair_none(self):
@ -160,6 +162,7 @@ class SignalTest(HeatTestCase):
self.assertIn('Error creating ec2 keypair', rsrc.status_reason)
self.assertEqual('123xyz', rs_data.get('user_id'))
self.assertIsNone(rsrc.resource_id)
self.m.VerifyAll()
@utils.stack_delete_after
def test_resource_data(self):
@ -193,6 +196,7 @@ class SignalTest(HeatTestCase):
self.assertEqual((rsrc.DELETE, rsrc.COMPLETE), rsrc.state)
rs_data = db_api.resource_data_get_all(rsrc)
self.assertEqual(1, len(rs_data.keys()))
self.m.VerifyAll()
@utils.stack_delete_after
def test_get_user_id(self):
@ -222,6 +226,7 @@ class SignalTest(HeatTestCase):
self.assertRaises(
exception.NotFound, db_api.resource_data_get, rsrc, 'user_id')
self.assertEqual('1234', rsrc._get_user_id())
self.m.VerifyAll()
@utils.stack_delete_after
def test_FnGetAtt_Alarm_Url(self):