From 624be98be0cad6270154f76e79d58f2f1ff1ea0d Mon Sep 17 00:00:00 2001 From: lidong Date: Thu, 1 Aug 2019 17:01:39 +0800 Subject: [PATCH] Fix Firewall policy resource OS::Neutron::FirewallPolicy resource cannot be created without firewall_rules. I can create firewall policy via the rest api of neutron.And in the rest api of neutron to create firewall policy ,the firewall_rules is an optional parameter. This should be consistent with the rest api of neutron. So I think the firewall_rules should be an optional property of OS::Neutron::FirewallPolicy resource. Add releasenote about this. Change-Id: I74cb22a7995376c2339f24fca9ca5d651d598480 Task: 36037 --- heat/engine/resources/openstack/neutron/firewall.py | 4 ++-- .../notes/update-firwallpolicy-ruls-90a8904e899b2365.yaml | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 releasenotes/notes/update-firwallpolicy-ruls-90a8904e899b2365.yaml diff --git a/heat/engine/resources/openstack/neutron/firewall.py b/heat/engine/resources/openstack/neutron/firewall.py index 740cb16bfe..fce59da817 100644 --- a/heat/engine/resources/openstack/neutron/firewall.py +++ b/heat/engine/resources/openstack/neutron/firewall.py @@ -243,8 +243,8 @@ class FirewallPolicy(neutron.NeutronResource): ), FIREWALL_RULES: properties.Schema( properties.Schema.LIST, - _('An ordered list of firewall rules to apply to the firewall.'), - required=True, + _('An ordered list of firewall rules to apply to the firewall. ' + '(Prior to version 14.0.0 this was a required property).'), update_allowed=True ), } diff --git a/releasenotes/notes/update-firwallpolicy-ruls-90a8904e899b2365.yaml b/releasenotes/notes/update-firwallpolicy-ruls-90a8904e899b2365.yaml new file mode 100644 index 0000000000..69049c9230 --- /dev/null +++ b/releasenotes/notes/update-firwallpolicy-ruls-90a8904e899b2365.yaml @@ -0,0 +1,5 @@ +--- +fixes: +- | + The `firewall_rules` property of the `OS::Neutron::FirewallPolicy` + resource type is now optional. \ No newline at end of file