From 6836c8f808b254af506e99ba78bba89ce5f913dd Mon Sep 17 00:00:00 2001 From: Steven Hardy Date: Fri, 25 Jan 2013 14:37:26 +0000 Subject: [PATCH] heat engine : error on resource update with invalid properties If properties validation fails, raise an error so the resource is marked as UPDATE_FAILED, we don't want to go ahead and try running handle_update anyway Change-Id: I5f748b9de6a2b02d26421a5b6e0b1b5f0db25d0c Signed-off-by: Steven Hardy --- heat/engine/resource.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/heat/engine/resource.py b/heat/engine/resource.py index aee065f436..52f1c34aa7 100644 --- a/heat/engine/resource.py +++ b/heat/engine/resource.py @@ -255,7 +255,7 @@ class Resource(object): self.t = self.stack.resolve_static_data(json_snippet) err = self.properties.validate() if err: - return err + raise ValueError(err) if callable(getattr(self, 'handle_update', None)): result = self.handle_update() except Exception as ex: