openstack/heat
Code Issues Proposed changes

Do deepcopy when copying templates

Browse Source 
test_template is defined as a dict, so do a deepcopy
instead.

Change-Id: I0f7d222d5f95aa8e8ed73ae0d7a100470271e113
Closes-Bug: #1766448
This commit is contained in:
rabi 2018-04-24 16:41:19 +05:30
parent 5b785eb227
commit 685f95b49d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
heat_integrationtests/functional/test_update_restricted.py
View File

@ -10,6 +10,7 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
import copy
import time import time
from heat_integrationtests.functional import functional_base from heat_integrationtests.functional import functional_base
@ -57,7 +58,7 @@ class UpdateRestrictedStackTest(functional_base.FunctionalTestsBase):
def test_update(self): def test_update(self):
stack_identifier = self.stack_create(template=test_template) stack_identifier = self.stack_create(template=test_template)
update_template = test_template.copy() update_template = copy.deepcopy(test_template)
props = update_template['resources']['bar']['properties'] props = update_template['resources']['bar']['properties']
props['value'] = '4567' props['value'] = '4567'
@ -94,7 +95,7 @@ class UpdateRestrictedStackTest(functional_base.FunctionalTestsBase):
def test_replace(self): def test_replace(self):
stack_identifier = self.stack_create(template=test_template) stack_identifier = self.stack_create(template=test_template)
update_template = test_template.copy() update_template = copy.deepcopy(test_template)
props = update_template['resources']['bar']['properties'] props = update_template['resources']['bar']['properties']
props['value'] = '4567' props['value'] = '4567'
props['update_replace'] = True props['update_replace'] = True
@ -132,7 +133,7 @@ class UpdateRestrictedStackTest(functional_base.FunctionalTestsBase):
def test_update_type_changed(self): def test_update_type_changed(self):
stack_identifier = self.stack_create(template=test_template) stack_identifier = self.stack_create(template=test_template)
update_template = test_template.copy() update_template = copy.deepcopy(test_template)
rsrc = update_template['resources']['bar'] rsrc = update_template['resources']['bar']
rsrc['type'] = 'OS::Heat::None' rsrc['type'] = 'OS::Heat::None'