openstack/heat
Code Issues Proposed changes

Fix pep8 E741 errors

Browse Source 
Change-Id: Ibb0da11fd89876602a6da62d08834937b81c2ce6
This commit is contained in:
Rabi Mishra 2020-05-12 11:11:39 +05:30
parent 4c5abb4909
commit 6d697ad2f0
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
heat/engine/resources/openstack/neutron/l2_gateway.py
View File

@ -111,8 +111,8 @@ class L2Gateway(neutron.NeutronResource):
in props.items() if v is not None) in props.items() if v is not None)
elif (isinstance(props, collections.Sequence) and elif (isinstance(props, collections.Sequence) and
not isinstance(props, str)): not isinstance(props, str)):
return list(L2Gateway._remove_none_value_props(l) for l in props return list(L2Gateway._remove_none_value_props(p) for p in props
if l is not None) if p is not None)
return props return props
@staticmethod @staticmethod

4
heat/tests/engine/test_dependencies.py
View File

@ -30,8 +30,8 @@ class dependenciesTest(common.HeatTestCase):
self.assertEqual(len(nodes), len(order)) self.assertEqual(len(nodes), len(order))
for l, f in deps: for lr, fr in deps:
checkorder(order.index(f), order.index(l)) checkorder(order.index(fr), order.index(lr))
def _dep_test_fwd(self, *deps): def _dep_test_fwd(self, *deps):
def assertLess(a, b): def assertLess(a, b):

2
heat/tests/fakes.py
View File

@ -58,7 +58,7 @@ class FakeClient(object):
break break
if not found: if not found:
raise AssertionError('Expected %s %s; got %s' % raise AssertionError('Expected %s; got %s' %
(expected, self.client.callstack)) (expected, self.client.callstack))
if body is not None: if body is not None:
if entry[2] != body: if entry[2] != body:

4
heat_integrationtests/common/test.py
View File

@ -482,7 +482,7 @@ class HeatIntegrationTest(testscenarios.WithScenarios,
def _get_nested_identifier(self, stack_identifier, res_name): def _get_nested_identifier(self, stack_identifier, res_name):
rsrc = self.client.resources.get(stack_identifier, res_name) rsrc = self.client.resources.get(stack_identifier, res_name)
nested_link = [l for l in rsrc.links if l['rel'] == 'nested'] nested_link = [lk for lk in rsrc.links if lk['rel'] == 'nested']
nested_href = nested_link[0]['href'] nested_href = nested_link[0]['href']
nested_id = nested_href.split('/')[-1] nested_id = nested_href.split('/')[-1]
nested_identifier = '/'.join(nested_href.split('/')[-2:]) nested_identifier = '/'.join(nested_href.split('/')[-2:])
@ -524,7 +524,7 @@ class HeatIntegrationTest(testscenarios.WithScenarios,
if (filter_func(r) if callable(filter_func) else True)) if (filter_func(r) if callable(filter_func) else True))
def get_resource_stack_id(self, r): def get_resource_stack_id(self, r):
stack_link = [l for l in r.links if l.get('rel') == 'stack'][0] stack_link = [lk for lk in r.links if lk.get('rel') == 'stack'][0]
return stack_link['href'].split("/")[-1] return stack_link['href'].split("/")[-1]
def get_physical_resource_id(self, stack_identifier, resource_name): def get_physical_resource_id(self, stack_identifier, resource_name):