openstack/heat
Code Issues Proposed changes

Add contrib to tox pep8 check

Browse Source 
This implements Clint's comment in
https://review.openstack.org/#/c/48690/1 adding # noqa
to the relative imports and adding contrib to the pep8 check.

run_tests.sh -p now returns no warnings.

Change-Id: I05085151258a6d0f3cc348211f64533fd4cbded9
Closes-Bug: #1234938
This commit is contained in:
Steve Baker
2013-10-04 10:06:45 +13:00
parent d61a8980bf
commit 6f81001f26
7 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
contrib/rackspace/heat/engine/plugins/cloud_loadbalancer.py
+1 -1
View File
@@ -24,7 +24,7 @@ from heat.engine import scheduler
from heat.engine.properties import Properties
from heat.common import exception
from . import rackspace_resource
from . import rackspace_resource # noqa
logger = logging.getLogger(__name__)
contrib/rackspace/heat/engine/plugins/cloud_server.py
+1 -1
View File
@@ -24,7 +24,7 @@ from heat.engine.resources import instance
from heat.engine.resources import nova_utils
from heat.db.sqlalchemy import api as db_api
from . import rackspace_resource
from . import rackspace_resource # noqa
logger = logging.getLogger(__name__)
contrib/rackspace/heat/engine/plugins/clouddatabase.py
+1 -1
View File
@@ -23,7 +23,7 @@ except ImportError:
from heat.common import exception
from heat.openstack.common import log as logging
from . import rackspace_resource
from . import rackspace_resource # noqa
logger = logging.getLogger(__name__)
contrib/rackspace/heat/tests/test_cloud_loadbalancer.py
+1 -1
View File
@@ -23,7 +23,7 @@ from heat.engine import resource
from heat.tests.common import HeatTestCase
from heat.tests import utils
from ..engine.plugins import cloud_loadbalancer as lb
from ..engine.plugins import cloud_loadbalancer as lb # noqa
# The following fakes are for pyrax
contrib/rackspace/heat/tests/test_clouddatabase.py
+1 -1
View File
@@ -21,7 +21,7 @@ from heat.openstack.common import uuidutils
from heat.tests.common import HeatTestCase
from heat.tests import utils
from ..engine.plugins import clouddatabase
from ..engine.plugins import clouddatabase # noqa
wp_template = '''
contrib/rackspace/heat/tests/test_rackspace_cloud_server.py
+2 -2
View File
@@ -28,8 +28,8 @@ from heat.openstack.common import uuidutils
from heat.tests.common import HeatTestCase
from heat.tests import utils
from ..engine.plugins import rackspace_resource
from ..engine.plugins import cloud_server
from ..engine.plugins import rackspace_resource # noqa
from ..engine.plugins import cloud_server # noqa
wp_template = '''
{
tox.ini
+2 -2
View File
@@ -14,11 +14,11 @@ deps = -r{toxinidir}/requirements.txt
-r{toxinidir}/test-requirements.txt
commands =
discover -s contrib/ {posargs}
flake8 --ignore=H304,F841,H201,H302,H306,H404 contrib
flake8 contrib
[testenv:pep8]
commands =
flake8 heat bin/heat-api bin/heat-api-cfn bin/heat-api-cloudwatch bin/heat-engine bin/heat-manage
flake8 heat bin/heat-api bin/heat-api-cfn bin/heat-api-cloudwatch bin/heat-engine bin/heat-manage contrib
{toxinidir}/tools/conf/check_uptodate.sh
[testenv:venv]