openstack/heat
Code Issues Proposed changes

Remove redundant lines in test_instance_group.py

Browse Source 
Fix the comment of commit ee086961a6,
to delete redundant lines of test.

Change-Id: Id618efada450b6ab1059777f529498e916fd0517
This commit is contained in:
huangtianhua 2016-03-16 18:00:03 +08:00
parent 6373e1f7a7
commit 708a5744f6
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
heat/tests/openstack/heat/test_instance_group.py
View File

@ -87,16 +87,13 @@ class TestInstanceGroup(common.HeatTestCase):
self.assertIn('(JobServerConfig) reference can not be found', self.assertIn('(JobServerConfig) reference can not be found',
six.text_type(error)) six.text_type(error))
# test resource name of instance group not WebServerGroup, so no ref # test resource name of instance group not WebServerGroup, so no ref
props = self.instance_group.properties.data
props['LaunchConfigurationName'] = 'LaunchConfig' props['LaunchConfigurationName'] = 'LaunchConfig'
error = self.assertRaises(ValueError, self.instance_group.validate) error = self.assertRaises(ValueError, self.instance_group.validate)
self.assertIn('LaunchConfigurationName (LaunchConfig) requires a ' self.assertIn('LaunchConfigurationName (LaunchConfig) requires a '
'reference to the configuration not just the ' 'reference to the configuration not just the '
'name of the resource.', 'name of the resource.',
six.text_type(error)) six.text_type(error))
# test validate ok # test validate ok if change instance_group name to 'WebServerGroup'
props = self.instance_group.properties.data
props['LaunchConfigurationName'] = 'LaunchConfig'
self.instance_group.name = 'WebServerGroup' self.instance_group.name = 'WebServerGroup'
self.instance_group.validate() self.instance_group.validate()