openstack
/
heat
Code Issues Proposed changes

Merge "Use __iter__ method of Attributes class in __repr__ method"

This commit is contained in:
Jenkins 2015-07-14 01:27:27 +00:00 committed by Gerrit Code Review
parent db11da5e5b 658d61ecee
commit 76a1044764
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
heat/engine/attributes.py
View File

@ -233,7 +233,7 @@ class Attributes(collections.Mapping):
def __repr__(self):
return ("Attributes for %s:\n\t" % self._resource_name +
'\n\t'.join(six.itervalues(self._attributes)))
'\n\t'.join(six.itervalues(self)))
def select_from_attribute(attribute_value, path):

9
heat/tests/test_attributes.py
View File

@ -110,6 +110,15 @@ class AttributesTest(common.HeatTestCase):
test_resolver)
self.assertEqual("value1", attribs['test1'])
def test_attributes_representation(self):
"""Test that attributes are displayed correct."""
test_resolver = lambda x: "value1"
attribs = attributes.Attributes('test resource',
self.attributes_schema,
test_resolver)
msg = 'Attributes for test resource:\n\tvalue1\n\tvalue1\n\tvalue1'
self.assertEqual(msg, str(attribs))
def test_get_attribute_none(self):
"""Test that we get the attribute values we expect."""
test_resolver = lambda x: None