openstack
/
heat
Code Issues Proposed changes

Enable H101 style check 

TODO must contain a name in parentheses

Change-Id: Ie535b8aa67403fb05e536af34d7bacfe3f08ce99
This commit is contained in:
Pavlo Shchelokovskyy 2014-12-14 19:43:34 +02:00
parent 9b70d30386
commit 8f801e29c8
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
heat/engine/api.py
View File

@ -95,11 +95,11 @@ def format_stack(stack, preview=False):
rpc_api.STACK_ID: dict(stack.identifier()),
rpc_api.STACK_CREATION_TIME: timeutils.isotime(stack.created_time),
rpc_api.STACK_UPDATED_TIME: updated_time,
rpc_api.STACK_NOTIFICATION_TOPICS: [], # TODO Not implemented yet
rpc_api.STACK_NOTIFICATION_TOPICS: [], # TODO(?) Not implemented yet
rpc_api.STACK_PARAMETERS: stack.parameters.map(str),
rpc_api.STACK_DESCRIPTION: stack.t[stack.t.DESCRIPTION],
rpc_api.STACK_TMPL_DESCRIPTION: stack.t[stack.t.DESCRIPTION],
rpc_api.STACK_CAPABILITIES: [], # TODO Not implemented yet
rpc_api.STACK_CAPABILITIES: [], # TODO(?) Not implemented yet
rpc_api.STACK_DISABLE_ROLLBACK: stack.disable_rollback,
rpc_api.STACK_TIMEOUT: stack.timeout_mins,
rpc_api.STACK_OWNER: stack.username,

3
tox.ini
View File

@ -57,7 +57,6 @@ commands =
# E265 block comment should start with '# '
# F402 import shadowed by loop variable
# F812 list comprehension redefines variable
# H101 Use TODO(NAME)
# H202 assertRaises Exception too broad
# H233 Python 3.x incompatible use of print operator
# H305 imports not grouped correctly
@ -67,7 +66,7 @@ commands =
# H405 multi line docstring summary not separated with an empty line
# H803 no full stop at the end of the commit message
# H904 Wrap long lines in parentheses instead of a backslash
ignore = E251,E265,F402,F812,H101,H202,H233,H305,H307,H402,H404,H405,H803,H904
ignore = E251,E265,F402,F812,H202,H233,H305,H307,H402,H404,H405,H803,H904
show-source = true
exclude=.venv,.git,.tox,dist,*openstack/common*,*lib/python*,*egg,tools,build
max-complexity=20