openstack
/
heat
Code Issues Proposed changes

Don't load resource data for list_outputs 

This RPC call only generates a list of the outputs defined in the template,
not their values, so don't load the resource data needed to calculate the
output values (which can be very slow).

Also, explicitly pass resolve_value=False instead of relying on the default
argument (which is different for format_stack_output() and
format_stack_outputs()), to reduce future confusion.

Change-Id: I79aae94b6552d465db6707cd4a40cd53ff18455b
Closes-Bug: #1719340
This commit is contained in:
Zane Bitter 2017-09-25 11:24:39 -04:00
parent 49d833f9ac
commit 9b5f66351f
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
heat/engine/service.py
View File

@ -1363,8 +1363,7 @@ class EngineService(service.ServiceBase):
s = self._get_stack(cntx, stack_identity)
stack = parser.Stack.load(cntx, stack=s)
stack._update_all_resource_data(for_resources=False, for_outputs=True)
return api.format_stack_outputs(stack.outputs)
return api.format_stack_outputs(stack.outputs, resolve_value=False)
@context.request_context
def show_output(self, cntx, stack_identity, output_key):