openstack
/
heat
Code Issues Proposed changes

Call db refresh in Stack object refresh 

The current Stack object refresh doesn't actually do any refreshing,
which explains the functional test speed regression since the RPC
nested stack code relies on stack.refresh() to poll for state change.

With this change AutoScalingSignalTest.test_signal_with_policy_update
locally takes ~60s consistently. Without this change ~50% of test runs
have some form of execution delay, taking 80s -> 300s+.

Change-Id: Ie06851fd5b0d8b802ebf701e8bf621562d9b6d88
Closes-Bug: #1433555
This commit is contained in:
Steve Baker 2015-03-20 11:33:03 +13:00
parent 34cc6d7e96
commit 9bb663d81b
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
heat/objects/stack.py
View File

@ -156,12 +156,11 @@ class Stack(
return super(Stack, self).__eq__(another)
def refresh(self):
db_stack = db_api.stack_get(
self._context, self.id, show_deleted=True)
db_stack.refresh()
return self.__class__._from_db_object(
self._context,
self,
db_api.stack_get(
self._context,
self.id,
show_deleted=True,
),
db_stack
)