openstack/heat
Code Issues Proposed changes

Do not initialize anything during import phase

Browse Source 
The structure of the program is compromised by doing too much logic in
the import phase. We can read the code more cleanly if we can see where
the intended initialization code is called. This may make tests slightly
more tedious to write, but that should be handled by writing generic
fixtures which can be reused for exactly this purpose.

Change-Id: I1d221e2f90d1f6e89717a37d2128caabd077d30a
This commit is contained in:
Clint Byrum
2013-04-23 15:51:57 -07:00
parent f3be3d90b3
commit a60f6d4569
16 changed files with 34 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
heat/tests/test_security_group.py
View File

@@ -28,7 +28,6 @@ from heat.tests.v1_1 import fakes
from novaclient.v1_1 import security_groups as nova_sg
from novaclient.v1_1 import security_group_rules as nova_sgr
NovaSG = collections.namedtuple('NovaSG',
' '.join([
'name',