Refactor test_share_create_failed test for Manila

test_share_create_failed check that check_create_complete
raises ResourceInError exception, but there is no necessity
to create whole resource, because if ResourceInError has been
raised, heat tries to recreate stack, thereforce
test_share_create_failed runs 68 seconds. Now test only checks
correct raising ResourceInError in check_create_complete.

Also, test_share_create_unknown_status was refactored in such way.

Change-Id: I5093a49bda00c676ef805dff1ecfb2e2db803a9c
This commit is contained in:
Peter Razumovsky 2015-07-07 12:25:05 +03:00
parent c8ce68ff5e
commit bc1701c0d3
1 changed files with 7 additions and 6 deletions

View File

@ -18,6 +18,7 @@ import six
from heat.common import exception
from heat.common import template_format
from heat.engine import resource
from heat.engine.resources.openstack.manila import share as mshare
from heat.engine import rsrc_defn
from heat.engine import scheduler
@ -113,18 +114,18 @@ class ManilaShareTest(common.HeatTestCase):
def test_share_create_fail(self):
share = self._init_share("stack_share_create_fail")
share.client().shares.create.return_value = self.fake_share
share.client().shares.get.return_value = self.failed_share
exc = self.assertRaises(exception.ResourceFailure,
scheduler.TaskRunner(share.create))
exc = self.assertRaises(resource.ResourceInError,
share.check_create_complete,
self.failed_share)
self.assertIn("Error during creation", six.text_type(exc))
def test_share_create_unknown_status(self):
share = self._init_share("stack_share_create_unknown")
share.client().shares.create.return_value = self.fake_share
share.client().shares.get.return_value = self.deleting_share
exc = self.assertRaises(exception.ResourceFailure,
scheduler.TaskRunner(share.create))
exc = self.assertRaises(resource.ResourceUnknownStatus,
share.check_create_complete,
self.deleting_share)
self.assertIn("Unknown status", six.text_type(exc))
def test_share_delete(self):