openstack/heat
Code Issues Proposed changes

Update functional tests missing skip check

Browse Source 
There are some test cases that still use the
test.HeatIntegrationTest base class instead of
the functional_base.FunctionalTestsBase base class.

The effect is that these tests will not check whether
they are skipped (e.g. by setting the
heat_plugin/skip_functional_tests oslo.config attr)
and in some cases end up being executed and reporting
false errors.

Change-Id: I074901f4d0c0c84fa09554e09095402fb9cf0b8e
Closes-Bug: #1699124
This commit is contained in:
Stefan Nica 2017-06-20 14:45:14 +02:00 committed by Rico Lin
parent 30c87bae3d
commit c4e8897fda
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
heat_integrationtests/functional/test_preview.py
View File

@ -10,12 +10,12 @@
# License for the specific language governing permissions and limitations
# under the License.
from heat_integrationtests.common import test
from heat_integrationtests.functional import functional_base
from heatclient import exc
import six
class StackPreviewTest(test.HeatIntegrationTest):
class StackPreviewTest(functional_base.FunctionalTestsBase):
template = '''
heat_template_version: 2015-04-30
parameters:

2
heat_integrationtests/functional/test_template_resource.py
View File

@ -740,7 +740,7 @@ resources:
self.stack_resume(stack_identifier=stack_identifier)
class ValidateFacadeTest(test.HeatIntegrationTest):
class ValidateFacadeTest(functional_base.FunctionalTestsBase):
"""Prove that nested stack errors don't suck."""
template = '''