From f204ad21ec78f01f402b168a0abb78b2254fc313 Mon Sep 17 00:00:00 2001 From: Thomas Herve Date: Mon, 16 Dec 2013 16:05:44 +0100 Subject: [PATCH] Remove useless validate methods Remove the validate methods of s3 and swift resources, as they don't provide any value and hide validation of properties. Change-Id: I5b9f7aef828d5e4d7cdebfd2bd550feaae545c90 Closes-Bug: #1260643 --- heat/engine/resources/s3.py | 9 --------- heat/engine/resources/swift.py | 9 --------- 2 files changed, 18 deletions(-) diff --git a/heat/engine/resources/s3.py b/heat/engine/resources/s3.py index 8908df8ed9..0faebbb6d2 100644 --- a/heat/engine/resources/s3.py +++ b/heat/engine/resources/s3.py @@ -100,15 +100,6 @@ class S3Bucket(resource.Resource): 'WebsiteURL': _('The website endpoint for the specified bucket.') } - def validate(self): - ''' - Validate any of the provided params - ''' - #check if swiftclient is installed - if clients.swiftclient is None: - return {'Error': - 'S3 services unavailable because of missing swiftclient.'} - def tags_to_headers(self): if self.properties[self.TAGS] is None: return {} diff --git a/heat/engine/resources/swift.py b/heat/engine/resources/swift.py index 98f65be480..0af64be53f 100644 --- a/heat/engine/resources/swift.py +++ b/heat/engine/resources/swift.py @@ -66,15 +66,6 @@ class SwiftContainer(resource.Resource): 'HeadContainer': _('A map containing all headers for the container.') } - def validate(self): - ''' - Validate any of the provided params - ''' - #check if swiftclient is installed - if clients.swiftclient is None: - return {'Error': - 'SwiftContainer unavailable due to missing swiftclient.'} - def physical_resource_name(self): name = self.properties.get(self.NAME) if name: