Implement OS::Neutron::SecurityGroup
Some notes on the implementation: * There is a single list of rules, with the 'direction' attribute denoting whether ingress or egress (ingress is the default) * All attributes are updatable without resource replacement using prepare_update_properties. * Rules update is implemented by: * deleting all rules * restoring default egress rules which allow all egress * adding new rules * The remote_mode attribute allows switching from remote_ip_prefix to remote_group_id based associations * As documented in the remote_group_id property, a rule can establish a self-reference to its own security group by specifying remote_mode: remote_group_id and not specifying any value for remote_group_id Implements blueprint native-neutron-securitygroup Partial-Bug: #1206313 Partial-Bug: #1243686 Change-Id: Id240fe02b5b85d7b11f48411a58e98d2d575c9a0
This commit is contained in:
Steve Baker
parent
3460a759d8
commit
f3ee60e7b5
|
|
@ -0,0 +1,233 @@
|
|||
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
||||
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
||||
# not use this file except in compliance with the License. You may obtain
|
||||
# a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
||||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
||||
# License for the specific language governing permissions and limitations
|
||||
# under the License.
|
||||
|
||||
from heat.common import exception
|
||||
from heat.engine import clients
|
||||
from heat.engine import properties
|
||||
from heat.engine.resources.neutron import neutron
|
||||
from heat.openstack.common import log as logging
|
||||
|
||||
if clients.neutronclient is not None:
|
||||
import neutronclient.common.exceptions as neutron_exp
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
|
||||
class SecurityGroup(neutron.NeutronResource):
|
||||
|
||||
rule_schema = {
|
||||
'direction': properties.Schema(
|
||||
properties.STRING,
|
||||
_('The direction in which the security group rule is applied. '
|
||||
'For a compute instance, an ingress security group rule '
|
||||
'matches traffic that is incoming (ingress) for that '
|
||||
'instance. An egress rule is applied to traffic leaving '
|
||||
'the instance.'),
|
||||
default='ingress',
|
||||
constraints=[properties.AllowedValues(('ingress', 'egress'))]
|
||||
),
|
||||
'ethertype': properties.Schema(
|
||||
properties.STRING,
|
||||
_('Ethertype of the traffic.'),
|
||||
default='IPv4',
|
||||
constraints=[properties.AllowedValues(('IPv4', 'IPv6'))]
|
||||
),
|
||||
'port_range_min': properties.Schema(
|
||||
properties.INTEGER,
|
||||
_('The minimum port number in the range that is matched by the '
|
||||
'security group rule. If the protocol is TCP or UDP, this '
|
||||
'value must be less than or equal to the value of the '
|
||||
'port_range_max attribute. If the protocol is ICMP, this '
|
||||
'value must be an ICMP type.')
|
||||
),
|
||||
'port_range_max': properties.Schema(
|
||||
properties.INTEGER,
|
||||
_('The maximum port number in the range that is matched by the '
|
||||
'security group rule. The port_range_min attribute constrains '
|
||||
'the port_range_max attribute. If the protocol is ICMP, this '
|
||||
'value must be an ICMP type.')
|
||||
),
|
||||
'protocol': properties.Schema(
|
||||
properties.STRING,
|
||||
_('The protocol that is matched by the security group rule. '
|
||||
'Valid values include tcp, udp, and icmp.')
|
||||
),
|
||||
'remote_mode': properties.Schema(
|
||||
properties.STRING,
|
||||
_('Whether to specify a remote group or a remote IP prefix.'),
|
||||
default='remote_ip_prefix',
|
||||
constraints=[properties.AllowedValues((
|
||||
'remote_ip_prefix', 'remote_group_id'))]
|
||||
),
|
||||
'remote_group_id': properties.Schema(
|
||||
properties.STRING,
|
||||
_('The remote group ID to be associated with this security group '
|
||||
'rule. If no value is specified then this rule will use this '
|
||||
'security group for the remote_group_id.')
|
||||
),
|
||||
'remote_ip_prefix': properties.Schema(
|
||||
properties.STRING,
|
||||
_('The remote IP prefix (CIDR) to be associated with this '
|
||||
'security group rule.')
|
||||
),
|
||||
}
|
||||
|
||||
properties_schema = {
|
||||
'name': properties.Schema(
|
||||
properties.STRING,
|
||||
_('A string specifying a symbolic name for '
|
||||
'the security group, which is not required to be '
|
||||
'unique.'),
|
||||
update_allowed=True
|
||||
),
|
||||
'description': properties.Schema(
|
||||
properties.STRING,
|
||||
_('Description of the security group.'),
|
||||
update_allowed=True
|
||||
),
|
||||
'rules': properties.Schema(
|
||||
properties.LIST,
|
||||
_('List of security group rules.'),
|
||||
default=[],
|
||||
schema=properties.Schema(
|
||||
properties.MAP,
|
||||
schema=rule_schema
|
||||
),
|
||||
update_allowed=True
|
||||
)
|
||||
}
|
||||
|
||||
default_egress_rules = [
|
||||
{"direction": "egress", "ethertype": "IPv4"},
|
||||
{"direction": "egress", "ethertype": "IPv6"}
|
||||
]
|
||||
|
||||
update_allowed_keys = ('Properties',)
|
||||
|
||||
def validate(self):
|
||||
super(SecurityGroup, self).validate()
|
||||
if self.properties.get('name') == 'default':
|
||||
msg = _('Security groups cannot be assigned the name "default".')
|
||||
raise exception.StackValidationFailed(message=msg)
|
||||
|
||||
def handle_create(self):
|
||||
props = self.prepare_properties(
|
||||
self.properties,
|
||||
self.physical_resource_name())
|
||||
rules = props.pop('rules', [])
|
||||
|
||||
sec = self.neutron().create_security_group(
|
||||
{'security_group': props})['security_group']
|
||||
|
||||
self.resource_id_set(sec['id'])
|
||||
self._create_rules(rules)
|
||||
|
||||
def _format_rule(self, r):
|
||||
rule = dict(r)
|
||||
rule['security_group_id'] = self.resource_id
|
||||
|
||||
if 'remote_mode' in rule:
|
||||
remote_mode = rule.get('remote_mode')
|
||||
del(rule['remote_mode'])
|
||||
|
||||
if remote_mode == 'remote_group_id':
|
||||
rule['remote_ip_prefix'] = None
|
||||
if not rule.get('remote_group_id'):
|
||||
# if remote group is not specified then make this
|
||||
# a self-referencing rule
|
||||
rule['remote_group_id'] = self.resource_id
|
||||
else:
|
||||
rule['remote_group_id'] = None
|
||||
|
||||
if rule.get('port_range_min', None) is not None:
|
||||
rule['port_range_min'] = str(rule['port_range_min'])
|
||||
if rule.get('port_range_max', None) is not None:
|
||||
rule['port_range_max'] = str(rule['port_range_max'])
|
||||
return rule
|
||||
|
||||
def _create_rules(self, rules):
|
||||
egress_deleted = False
|
||||
|
||||
for i in rules:
|
||||
if i['direction'] == 'egress' and not egress_deleted:
|
||||
# There is at least one egress rule, so delete the default
|
||||
# rules which allow all egress traffic
|
||||
egress_deleted = True
|
||||
|
||||
def is_egress(rule):
|
||||
return rule['direction'] == 'egress'
|
||||
|
||||
self._delete_rules(is_egress)
|
||||
|
||||
rule = self._format_rule(i)
|
||||
|
||||
try:
|
||||
self.neutron().create_security_group_rule(
|
||||
{'security_group_rule': rule})
|
||||
except neutron_exp.NeutronClientException as ex:
|
||||
# ignore error if rule already exists
|
||||
if ex.status_code != 409:
|
||||
raise
|
||||
|
||||
def _delete_rules(self, to_delete=None):
|
||||
try:
|
||||
sec = self.neutron().show_security_group(
|
||||
self.resource_id)['security_group']
|
||||
except neutron_exp.NeutronClientException as ex:
|
||||
if ex.status_code != 404:
|
||||
raise
|
||||
else:
|
||||
for rule in sec['security_group_rules']:
|
||||
if to_delete is None or to_delete(rule):
|
||||
try:
|
||||
self.neutron().delete_security_group_rule(rule['id'])
|
||||
except neutron_exp.NeutronClientException as ex:
|
||||
if ex.status_code != 404:
|
||||
raise
|
||||
|
||||
def handle_delete(self):
|
||||
|
||||
if self.resource_id is None:
|
||||
return
|
||||
|
||||
self._delete_rules()
|
||||
try:
|
||||
self.neutron().delete_security_group(self.resource_id)
|
||||
except neutron_exp.NeutronClientException as ex:
|
||||
if ex.status_code != 404:
|
||||
raise
|
||||
self.resource_id_set(None)
|
||||
|
||||
def handle_update(self, json_snippet, tmpl_diff, prop_diff):
|
||||
props = self.prepare_update_properties(json_snippet)
|
||||
rules = props.pop('rules', [])
|
||||
|
||||
self.neutron().update_security_group(
|
||||
self.resource_id, {'security_group': props})
|
||||
|
||||
# handle rules changes by:
|
||||
# * deleting all rules
|
||||
# * restoring the default egress rules
|
||||
# * creating new rules
|
||||
self._delete_rules()
|
||||
self._create_rules(self.default_egress_rules)
|
||||
if rules:
|
||||
self._create_rules(rules)
|
||||
|
||||
|
||||
def resource_mapping():
|
||||
return {
|
||||
'OS::Neutron::SecurityGroup': SecurityGroup,
|
||||
}
|
||||
|
|
@ -0,0 +1,771 @@
|
|||
# vim: tabstop=4 shiftwidth=4 softtabstop=4
|
||||
|
||||
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
||||
# not use this file except in compliance with the License. You may obtain
|
||||
# a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
||||
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
||||
# License for the specific language governing permissions and limitations
|
||||
# under the License.
|
||||
|
||||
from heat.common import exception
|
||||
from heat.common import template_format
|
||||
from heat.engine import clients
|
||||
from heat.engine import parser
|
||||
from heat.engine import scheduler
|
||||
from heat.tests.common import HeatTestCase
|
||||
from heat.tests.fakes import FakeKeystoneClient
|
||||
from heat.tests.v1_1 import fakes
|
||||
from heat.tests import utils
|
||||
|
||||
from novaclient.v1_1 import security_groups as nova_sg
|
||||
from novaclient.v1_1 import security_group_rules as nova_sgr
|
||||
from neutronclient.common.exceptions import NeutronClientException
|
||||
from neutronclient.v2_0 import client as neutronclient
|
||||
|
||||
|
||||
class SecurityGroupTest(HeatTestCase):
|
||||
|
||||
test_template = '''
|
||||
HeatTemplateFormatVersion: '2012-12-12'
|
||||
Resources:
|
||||
the_sg:
|
||||
Type: OS::Neutron::SecurityGroup
|
||||
Properties:
|
||||
description: HTTP and SSH access
|
||||
rules:
|
||||
- port_range_min: 22
|
||||
port_range_max: 22
|
||||
remote_ip_prefix: 0.0.0.0/0
|
||||
protocol: tcp
|
||||
- port_range_min: 80
|
||||
port_range_max: 80
|
||||
protocol: tcp
|
||||
remote_ip_prefix: 0.0.0.0/0
|
||||
- remote_mode: remote_group_id
|
||||
remote_group_id: wwww
|
||||
protocol: tcp
|
||||
- direction: egress
|
||||
port_range_min: 22
|
||||
port_range_max: 22
|
||||
protocol: tcp
|
||||
remote_ip_prefix: 10.0.1.0/24
|
||||
- direction: egress
|
||||
remote_mode: remote_group_id
|
||||
remote_group_id: xxxx
|
||||
- direction: egress
|
||||
remote_mode: remote_group_id
|
||||
'''
|
||||
|
||||
test_template_update = '''
|
||||
HeatTemplateFormatVersion: '2012-12-12'
|
||||
Resources:
|
||||
the_sg:
|
||||
Type: OS::Neutron::SecurityGroup
|
||||
Properties:
|
||||
description: SSH access for private network
|
||||
name: myrules
|
||||
rules:
|
||||
- port_range_min: 22
|
||||
port_range_max: 22
|
||||
remote_ip_prefix: 10.0.0.10/24
|
||||
protocol: tcp
|
||||
'''
|
||||
|
||||
test_template_validate = '''
|
||||
HeatTemplateFormatVersion: '2012-12-12'
|
||||
Resources:
|
||||
the_sg:
|
||||
Type: OS::Neutron::SecurityGroup
|
||||
Properties:
|
||||
name: default
|
||||
'''
|
||||
|
||||
def setUp(self):
|
||||
super(SecurityGroupTest, self).setUp()
|
||||
self.fc = fakes.FakeClient()
|
||||
self.m.StubOutWithMock(clients.OpenStackClients, 'nova')
|
||||
self.m.StubOutWithMock(clients.OpenStackClients, 'keystone')
|
||||
self.m.StubOutWithMock(nova_sgr.SecurityGroupRuleManager, 'create')
|
||||
self.m.StubOutWithMock(nova_sgr.SecurityGroupRuleManager, 'delete')
|
||||
self.m.StubOutWithMock(nova_sg.SecurityGroupManager, 'create')
|
||||
self.m.StubOutWithMock(nova_sg.SecurityGroupManager, 'delete')
|
||||
self.m.StubOutWithMock(nova_sg.SecurityGroupManager, 'get')
|
||||
self.m.StubOutWithMock(nova_sg.SecurityGroupManager, 'list')
|
||||
utils.setup_dummy_db()
|
||||
self.m.StubOutWithMock(neutronclient.Client, 'create_security_group')
|
||||
self.m.StubOutWithMock(
|
||||
neutronclient.Client, 'create_security_group_rule')
|
||||
self.m.StubOutWithMock(neutronclient.Client, 'show_security_group')
|
||||
self.m.StubOutWithMock(
|
||||
neutronclient.Client, 'delete_security_group_rule')
|
||||
self.m.StubOutWithMock(neutronclient.Client, 'delete_security_group')
|
||||
self.m.StubOutWithMock(neutronclient.Client, 'update_security_group')
|
||||
|
||||
def create_stack(self, template):
|
||||
t = template_format.parse(template)
|
||||
self.stack = self.parse_stack(t)
|
||||
self.assertEqual(None, self.stack.create())
|
||||
return self.stack
|
||||
|
||||
def parse_stack(self, t):
|
||||
stack_name = 'test_stack'
|
||||
tmpl = parser.Template(t)
|
||||
stack = parser.Stack(utils.dummy_context(), stack_name, tmpl)
|
||||
stack.store()
|
||||
return stack
|
||||
|
||||
def assertResourceState(self, rsrc, ref_id, metadata={}):
|
||||
self.assertEqual(None, rsrc.validate())
|
||||
self.assertEqual((rsrc.CREATE, rsrc.COMPLETE), rsrc.state)
|
||||
self.assertEqual(ref_id, rsrc.FnGetRefId())
|
||||
self.assertEqual(metadata, dict(rsrc.metadata))
|
||||
|
||||
@utils.stack_delete_after
|
||||
def test_security_group(self):
|
||||
|
||||
show_created = {'security_group': {
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'name': 'sc1',
|
||||
'description': '',
|
||||
'security_group_rules': [{
|
||||
'direction': 'ingress',
|
||||
'protocol': 'tcp',
|
||||
'port_range_max': '22',
|
||||
'id': 'bbbb',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': '22'
|
||||
}, {
|
||||
'direction': 'ingress',
|
||||
'protocol': 'tcp',
|
||||
'port_range_max': '80',
|
||||
'id': 'cccc',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': '80'
|
||||
}, {
|
||||
'direction': 'ingress',
|
||||
'protocol': 'tcp',
|
||||
'port_range_max': None,
|
||||
'id': 'dddd',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': 'wwww',
|
||||
'remote_ip_prefix': None,
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': None
|
||||
}, {
|
||||
'direction': 'egress',
|
||||
'protocol': 'tcp',
|
||||
'port_range_max': '22',
|
||||
'id': 'eeee',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '10.0.1.0/24',
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': '22'
|
||||
}, {
|
||||
'direction': 'egress',
|
||||
'protocol': None,
|
||||
'port_range_max': None,
|
||||
'id': 'ffff',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': 'xxxx',
|
||||
'remote_ip_prefix': None,
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': None
|
||||
}, {
|
||||
'direction': 'egress',
|
||||
'protocol': None,
|
||||
'port_range_max': None,
|
||||
'id': 'gggg',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': 'aaaa',
|
||||
'remote_ip_prefix': None,
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': None
|
||||
}],
|
||||
'id': 'aaaa'}
|
||||
}
|
||||
|
||||
#create script
|
||||
clients.OpenStackClients.keystone().AndReturn(
|
||||
FakeKeystoneClient())
|
||||
sg_name = utils.PhysName('test_stack', 'the_sg')
|
||||
neutronclient.Client.create_security_group({
|
||||
'security_group': {
|
||||
'name': sg_name,
|
||||
'description': 'HTTP and SSH access'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group': {
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'name': sg_name,
|
||||
'description': 'HTTP and SSH access',
|
||||
'security_group_rules': [{
|
||||
"direction": "egress",
|
||||
"ethertype": "IPv4",
|
||||
"id": "aaaa-1",
|
||||
"port_range_max": None,
|
||||
"port_range_min": None,
|
||||
"protocol": None,
|
||||
"remote_group_id": None,
|
||||
"remote_ip_prefix": None,
|
||||
"security_group_id": "aaaa",
|
||||
"tenant_id": "f18ca530cc05425e8bac0a5ff92f7e88"
|
||||
}, {
|
||||
"direction": "egress",
|
||||
"ethertype": "IPv6",
|
||||
"id": "aaaa-2",
|
||||
"port_range_max": None,
|
||||
"port_range_min": None,
|
||||
"protocol": None,
|
||||
"remote_group_id": None,
|
||||
"remote_ip_prefix": None,
|
||||
"security_group_id": "aaaa",
|
||||
"tenant_id": "f18ca530cc05425e8bac0a5ff92f7e88"
|
||||
}],
|
||||
'id': 'aaaa'
|
||||
}
|
||||
})
|
||||
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'port_range_min': '22',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '22',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'port_range_min': '22',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '22',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'bbbb'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'port_range_min': '80',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '80',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'port_range_min': '80',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '80',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'cccc'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': 'wwww',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': 'wwww',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'dddd'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.show_security_group('aaaa').AndReturn({
|
||||
'security_group': {
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'name': sg_name,
|
||||
'description': 'HTTP and SSH access',
|
||||
'security_group_rules': [{
|
||||
"direction": "egress",
|
||||
"ethertype": "IPv4",
|
||||
"id": "aaaa-1",
|
||||
"port_range_max": None,
|
||||
"port_range_min": None,
|
||||
"protocol": None,
|
||||
"remote_group_id": None,
|
||||
"remote_ip_prefix": None,
|
||||
"security_group_id": "aaaa",
|
||||
"tenant_id": "f18ca530cc05425e8bac0a5ff92f7e88"
|
||||
}, {
|
||||
"direction": "egress",
|
||||
"ethertype": "IPv6",
|
||||
"id": "aaaa-2",
|
||||
"port_range_max": None,
|
||||
"port_range_min": None,
|
||||
"protocol": None,
|
||||
"remote_group_id": None,
|
||||
"remote_ip_prefix": None,
|
||||
"security_group_id": "aaaa",
|
||||
"tenant_id": "f18ca530cc05425e8bac0a5ff92f7e88"
|
||||
}],
|
||||
'id': 'aaaa'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.delete_security_group_rule('aaaa-1').AndReturn(
|
||||
None)
|
||||
neutronclient.Client.delete_security_group_rule('aaaa-2').AndReturn(
|
||||
None)
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '10.0.1.0/24',
|
||||
'port_range_min': '22',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '22',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '10.0.1.0/24',
|
||||
'port_range_min': '22',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '22',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'eeee'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': 'xxxx',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': None,
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': 'xxxx',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': None,
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'ffff'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': 'aaaa',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': None,
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': 'aaaa',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': None,
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'gggg'
|
||||
}
|
||||
})
|
||||
|
||||
# update script
|
||||
neutronclient.Client.update_security_group(
|
||||
'aaaa',
|
||||
{'security_group': {
|
||||
'description': 'SSH access for private network',
|
||||
'name': 'myrules'}}
|
||||
).AndReturn({
|
||||
'security_group': {
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'name': 'myrules',
|
||||
'description': 'SSH access for private network',
|
||||
'security_group_rules': [],
|
||||
'id': 'aaaa'
|
||||
}
|
||||
})
|
||||
|
||||
neutronclient.Client.show_security_group('aaaa').AndReturn(
|
||||
show_created)
|
||||
neutronclient.Client.delete_security_group_rule('bbbb').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('cccc').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('dddd').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('eeee').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('ffff').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('gggg').AndReturn(None)
|
||||
|
||||
neutronclient.Client.show_security_group('aaaa').AndReturn({
|
||||
'security_group': {
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'name': 'sc1',
|
||||
'description': '',
|
||||
'security_group_rules': [],
|
||||
'id': 'aaaa'
|
||||
}
|
||||
})
|
||||
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': None,
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'hhhh'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'ethertype': 'IPv6',
|
||||
'security_group_id': 'aaaa',
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv6',
|
||||
'port_range_max': None,
|
||||
'protocol': None,
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'iiii'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '10.0.0.10/24',
|
||||
'port_range_min': '22',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '22',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '10.0.0.10/24',
|
||||
'port_range_min': '22',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '22',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa',
|
||||
'id': 'jjjj'
|
||||
}
|
||||
})
|
||||
|
||||
# delete script
|
||||
neutronclient.Client.show_security_group('aaaa').AndReturn(
|
||||
show_created)
|
||||
neutronclient.Client.delete_security_group_rule('bbbb').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('cccc').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('dddd').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('eeee').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('ffff').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group_rule('gggg').AndReturn(None)
|
||||
neutronclient.Client.delete_security_group('aaaa').AndReturn(None)
|
||||
|
||||
self.m.ReplayAll()
|
||||
stack = self.create_stack(self.test_template)
|
||||
|
||||
sg = stack['the_sg']
|
||||
self.assertResourceState(sg, 'aaaa')
|
||||
|
||||
updated_tmpl = template_format.parse(self.test_template_update)
|
||||
updated_stack = utils.parse_stack(updated_tmpl)
|
||||
stack.update(updated_stack)
|
||||
|
||||
stack.delete()
|
||||
self.m.VerifyAll()
|
||||
|
||||
@utils.stack_delete_after
|
||||
def test_security_group_exception(self):
|
||||
#create script
|
||||
clients.OpenStackClients.keystone().AndReturn(
|
||||
FakeKeystoneClient())
|
||||
sg_name = utils.PhysName('test_stack', 'the_sg')
|
||||
neutronclient.Client.create_security_group({
|
||||
'security_group': {
|
||||
'name': sg_name,
|
||||
'description': 'HTTP and SSH access'
|
||||
}
|
||||
}).AndReturn({
|
||||
'security_group': {
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'name': sg_name,
|
||||
'description': 'HTTP and SSH access',
|
||||
'security_group_rules': [],
|
||||
'id': 'aaaa'
|
||||
}
|
||||
})
|
||||
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'port_range_min': '22',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '22',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndRaise(
|
||||
NeutronClientException(status_code=409))
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'port_range_min': '80',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '80',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndRaise(
|
||||
NeutronClientException(status_code=409))
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'ingress',
|
||||
'remote_group_id': 'wwww',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndRaise(
|
||||
NeutronClientException(status_code=409))
|
||||
neutronclient.Client.show_security_group('aaaa').AndReturn({
|
||||
'security_group': {
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'name': sg_name,
|
||||
'description': 'HTTP and SSH access',
|
||||
'security_group_rules': [],
|
||||
'id': 'aaaa'
|
||||
}
|
||||
})
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '10.0.1.0/24',
|
||||
'port_range_min': '22',
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': '22',
|
||||
'protocol': 'tcp',
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndRaise(
|
||||
NeutronClientException(status_code=409))
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': 'xxxx',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': None,
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndRaise(
|
||||
NeutronClientException(status_code=409))
|
||||
neutronclient.Client.create_security_group_rule({
|
||||
'security_group_rule': {
|
||||
'direction': 'egress',
|
||||
'remote_group_id': 'aaaa',
|
||||
'remote_ip_prefix': None,
|
||||
'port_range_min': None,
|
||||
'ethertype': 'IPv4',
|
||||
'port_range_max': None,
|
||||
'protocol': None,
|
||||
'security_group_id': 'aaaa'
|
||||
}
|
||||
}).AndRaise(
|
||||
NeutronClientException(status_code=409))
|
||||
|
||||
# delete script
|
||||
neutronclient.Client.show_security_group('aaaa').AndReturn({
|
||||
'security_group': {
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'name': 'sc1',
|
||||
'description': '',
|
||||
'security_group_rules': [{
|
||||
'direction': 'ingress',
|
||||
'protocol': 'tcp',
|
||||
'port_range_max': '22',
|
||||
'id': 'bbbb',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': '22'
|
||||
}, {
|
||||
'direction': 'ingress',
|
||||
'protocol': 'tcp',
|
||||
'port_range_max': '80',
|
||||
'id': 'cccc',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '0.0.0.0/0',
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': '80'
|
||||
}, {
|
||||
'direction': 'ingress',
|
||||
'protocol': 'tcp',
|
||||
'port_range_max': None,
|
||||
'id': 'dddd',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': 'wwww',
|
||||
'remote_ip_prefix': None,
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': None
|
||||
}, {
|
||||
'direction': 'egress',
|
||||
'protocol': 'tcp',
|
||||
'port_range_max': '22',
|
||||
'id': 'eeee',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': '10.0.1.0/24',
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': '22'
|
||||
}, {
|
||||
'direction': 'egress',
|
||||
'protocol': None,
|
||||
'port_range_max': None,
|
||||
'id': 'ffff',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': 'xxxx',
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': None
|
||||
}, {
|
||||
'direction': 'egress',
|
||||
'protocol': None,
|
||||
'port_range_max': None,
|
||||
'id': 'gggg',
|
||||
'ethertype': 'IPv4',
|
||||
'security_group_id': 'aaaa',
|
||||
'remote_group_id': None,
|
||||
'remote_ip_prefix': 'aaaa',
|
||||
'tenant_id': 'f18ca530cc05425e8bac0a5ff92f7e88',
|
||||
'port_range_min': None
|
||||
}],
|
||||
'id': 'aaaa'}})
|
||||
neutronclient.Client.delete_security_group_rule('bbbb').AndRaise(
|
||||
NeutronClientException(status_code=404))
|
||||
neutronclient.Client.delete_security_group_rule('cccc').AndRaise(
|
||||
NeutronClientException(status_code=404))
|
||||
neutronclient.Client.delete_security_group_rule('dddd').AndRaise(
|
||||
NeutronClientException(status_code=404))
|
||||
neutronclient.Client.delete_security_group_rule('eeee').AndRaise(
|
||||
NeutronClientException(status_code=404))
|
||||
neutronclient.Client.delete_security_group_rule('ffff').AndRaise(
|
||||
NeutronClientException(status_code=404))
|
||||
neutronclient.Client.delete_security_group_rule('gggg').AndRaise(
|
||||
NeutronClientException(status_code=404))
|
||||
neutronclient.Client.delete_security_group('aaaa').AndRaise(
|
||||
NeutronClientException(status_code=404))
|
||||
|
||||
neutronclient.Client.show_security_group('aaaa').AndRaise(
|
||||
NeutronClientException(status_code=404))
|
||||
|
||||
self.m.ReplayAll()
|
||||
stack = self.create_stack(self.test_template)
|
||||
|
||||
sg = stack['the_sg']
|
||||
|
||||
self.assertResourceState(sg, 'aaaa')
|
||||
|
||||
scheduler.TaskRunner(sg.delete)()
|
||||
|
||||
sg.state_set(sg.CREATE, sg.COMPLETE, 'to delete again')
|
||||
sg.resource_id = 'aaaa'
|
||||
stack.delete()
|
||||
|
||||
self.m.VerifyAll()
|
||||
|
||||
@utils.stack_delete_after
|
||||
def test_security_group_validate(self):
|
||||
stack = self.create_stack(self.test_template_validate)
|
||||
sg = stack['the_sg']
|
||||
ex = self.assertRaises(exception.StackValidationFailed, sg.validate)
|
||||
self.assertEqual(
|
||||
'Security groups cannot be assigned the name "default".',
|
||||
ex.message)
|
||||
Loading…
Reference in New Issue