Instead of calling check_resource on all leaves in the resource graph at
once, sleep a little bit between each call. As it's a tad slower,
delegate it to a thread so that the stack_create RPC message doesn't
timeout when you have lots of resources.
Change-Id: I84d2b34d65b3ce7d8d858de106dac531aff509b7
Partial-Bug: #1566845
Where strings are continued across multiple lines, it's easy to miss a
space. This fixes several incorrect strings, cleans up some formatting
(don't line break inside a format specifier) and fixes typos.
Change-Id: Id781b16cad03c32973a67c02ad22ce4459c6d126
When merging multiple envs, 0 values where ignored in later envs, not
taking precedence. This fixes it by checking for None instead.
Change-Id: Ia0da6988f92825bcc9a19dd3dcce771baa978a59
Closes-Bug: #1669442
The list_events rpc api no longer includes resource properties data
when returning multiple events. In the "show event" case where an event
uuid is included in the list_events request, the resource properties data
for that single event continues to be included in the output.
Note that there is no change in behaviour on the heat-api side (see
heat/api/openstack/v1/events.py). Previously when listing multiple
events, it had just been ignoring the resource properties data it
fetched from the list_events rpc api, not including it in the output
it returned (e.g., to python-heatclient).
Change-Id: I7ac83d848cdd0e6c313870c0a4d59a5d9b2301f5
Partial-Bug: #1665506
Save the db and memory overhead associated with fetching a
raw_template when soft-deleting a stack or getting a root stack id.
Change-Id: I8cf575e4908764c4c5eb24185ec229254e30d58b
If getting an output from a child stack fails with an error, we didn't pass
on the error message to the parent stack that was requesting it but instead
reported essentially that the given output did not exist.
Change-Id: I5653baf310a29dc4829ad570c769cf67ce12695e
Partial-Bug: #1599114
Add full path field for Property class. Now
properties with sub-schemas should contain properties
with path, where their parent specified. For example,
if there is schema:
"a": type map:
schema:
"b": type string,
"c": type string
Then property "a" has path == 'a', "b" has path == 'a.b',
"c" has path == 'a.c'.
Change-Id: I6d0ba022f34b925d47142669d6076ebd63a2acdc
Related-bug: #1620859
Currently Properties has arg "parent_name", which
is used for detailed path in error and allows to
build path for nested properties schemas. But on
top parent_name takes resource name as initial,
which is few incorrect - Properties should raises
with error about Properties, other info (about in
what resource this error raised) should be built out of
Properties module.
Change-Id: I36e6453a1589c02a3f8cf2c080b38693b23b0f1b
Related-bug: #1620859
Previously, if a resource was in a FAILED state Heat would set the hook
but not wait for the user to clear it before continuing. It is not clear
what case this was designed to handle, since there's no way that I know
of for the resource to go into a FAILED state while waiting for the
hook.
Change-Id: Iaacc585b9806c08fd5a57c80c10eeb31cb0a8f71
Closes-Bug: #1665699
We stop showing json deserialized message in debug log, because
message will involved with some private credential message (like
password). Let's block it for now, until we get a better solution.
Partial-Bug: #1664792
Change-Id: I07410df56449c5414a5572d07507e17f5858c5c6
Working towards the goal of storing resource attributes in the db so
as to avoid re-resolving them when appropriate. Adds an 'attr_data'
object to the resource object, defined as a relationship on the
already existing resource_properties_data table.
Change-Id: I2104078d850da08b22547d7feab2bde00c543478
Partial-Bug: #1660831
To check whether detach_interface/attach_interface
complete to keep consistent with nova underlying.
Change-Id: I62e61a2d3633fac35655a8542f93921a1ba17930
Closes-Bug: #1650439
Don't create a resource record for backup stack if the
resource record exists, just to migrate it to backup
stack, to avoid redundant data remaining for existing
stack.
This patch also adds resource.store() which covers
_store() and _store_or_update() implemention. And then
we can delete the two methods.
Change-Id: I0b4b983306ea84fab0e2c81876ef407a80d25989
Closes-Bug: #1662095
In stack-update for network object with no fixed ip address:
Resource UPDATE failed: IndexError: resources.A_Server:
list index out of range
Change-Id: I47bc35f0391af21d64918e82a73db3afa43c2608
Closes-Bug: #1660809
Storing in self._user_domain was actually relying on the
oslo_context.RequestContext also storing in self._user_domain, however
this was renamed in change I203acefae8270bd3373b006fa096bea5ef3106f3
to _user_domain_id.
This change switches to _user_domain_id, which avoids infinite
recursion in the heat tripleo undercloud installer.
Change-Id: I1114611f6765e94dcab74943078066bb096f4078
Closes-Bug: #1663013
There is no need to reset other resources' attributes in the stack
when a resource calls state_set(), the other resources attributes will
get updated as they are visited. This is not a huge performance gain
since those resources would have been in memory anyway, but let's not
use the big hammer if we don't have to.
Change-Id: Icafd770055a3dc2f1f3262753a8dca045e38972d
Add additional check, is property in response body or
it will return incorrect data for update instead.
Change-Id: I2b70da243a4bf9d0beb01faf3d4057d2bfe93eb2
Closes-bug: #1662099
We seem to be unnecessarily using keystone client for
auth_ref. Use get_access from auth_plugin instead.
This removes the properties auth_token and auth_ref from
keystone client wrapper.
Change-Id: I99cc89b6013a98dca4fcbf3840d5bb83afa6e3d5
Typically when retrieving a large number of events, we don't need to
load resource_properties_data for each event.
Change-Id: I6564fea91d19c24409075152a614cc036dc1ee34
This reverts commit 94565e7097.
Apparently the extra overhead of converting the testr storage format to subunit doubles the size of the file, placing in on the borderline of the gate's 50MB limit, which is inexplicably applied to the uncompressed data (this change added only ~200kB to the size of the gzipped subunit file afaict).
Change-Id: Ic458be0fa273c1ba94dacb9a5233220ccc7c606d
Thomas Herve