All the volume_tasks logic has been redistributed as methods of either
cinder or nova client plugins.
The logic of detaching was simplified and a check for out-of-band
changes is no longer executed.
The old VolumeAttachTask is left in place as it is still used in
creating the AWS::EC2::Instance resource.
Change-Id: I13f8e03ff090dd5f5739e5af231c77d066eb9eac
Partial-Bug: #1393268
Circular references cause practically every bit of data that Heat uses to
remain in memory until the completion of an operation, and even then to
only be freed once the loop is detected by the garbage collector. By
breaking all of the loops using weak references, we can ensure that things
will get freed when they are no longer referenced without the need to wait
for garbage collection (which should also take a lot less time). This
change removes the loops from Resource and Function objects back to the
Stack.
Change-Id: Ibf80e95e69a2f27ed29754a2e0f1125e8eed0775
Closes-Bug: #1454873
There are some improvement of error message and tests
related of bug/1451713.
Change-Id: I78b609c8f1c8d04835f4a9dbadae51e2013fa753
Related-Bug: #1451713
Add a new constraint for CIDR format validation.
Implemented: blueprint enhance-property-constraints
Change-Id: Ica70147b713992c8523b92b12db0172a2966719c
This is the only thread that gets started without an explicit reference to
the stack. This prevents us from using a weakref in the resource, as it
will cause the Stack's reference count to hit 0 before the thread is run.
Now we explicitly pass a reference to the stack.
Change-Id: Ie51be7b54d97ef184e401e395a7e7e3a26ce003b
Related-Bug: #1454873
This will allow Resources to hold weak references to Stacks (so as to avoid
circular references) without causing the Stack object to be prematurely
deleted.
Change-Id: Ia76da7bc51042fb3598ef2a660d6fbf78137a37b
Related-Bug: #1454873
In order to eliminate circular references, we need to define the Stack as
the top of any reference hierarchy. This means we can't hold a reference to
a Resource directly without also holding a reference to its Stack.
Change-Id: I7430b109bbe1c5d6d64be9b8c778b394e9cff269
Related-Bug: #1454873
Use unittest2.assertWarnsRegex() for making sure we generate the
required warnings.
Use WarningsCapture to not print the other repeated warns to the
console.
Change-Id: I7223f8956394208eaf2eb8a1d651ba1425128bc9
Remove unnecessary using self.properties.get for more
clear code. Using properties.get(prop, default) causes
next issues:
1. properties.get(prop) if prop not in properties_schema
will return None instead of expected KeyError.
2. properties.get(prop, default) returns "default" value
if current properties is not presented in properties_schema.
So using self.properties.get() makes sense only when we plan
to use this property with default option in another resource,
which has not it in property schema.
This patch replaces this methods in resources/openstack folder.
Change-Id: I523eb3feacb0cb7a16a928a92896ce56188e376f
Docs still tells that Heat is configured by default on
devstack. Need to fix it.
Change-Id: I186415f3422f3865aa3fbf4fe83ef13ea73c7eed
Closes-bug: #1450422
Heat stack_resource has similar check for actions, but currently it does
not raise error if actions are different. OS::Heat::Stack resource is
similar on stack_resource so it has same issue, when resources require
some time to change state/action and it should not be so strict.
Change-Id: I20c2d3f8900b7393b1f551384805a35d5ef6497d
Closes-Bug: #1454589
Add validation for cinder volume, should specify only one
of snapshot_id, image, source_volid if don't specify backup_id
or size.
And also add validation of image and imageRef, user can't
set both of them.
Change-Id: Ibc9e75c338d07896e399267c366dd9167229ba9d
Closes-Bug: #1451713
This patch adds constraint for mac address validation.
Implemented: blueprint enhance-property-constraints
Change-Id: I8770177f96dc220bbfaf120a61877d77ddca5510
This sends a manual ceilometer sample to trigger the alarm,
then confirms that the autoscale policy/group reacts correctly.
Note: this doesn't used ScenarioBaseTest as it skips the test
unnecessarily on unused images and networks.
Change-Id: I5c842779d90497ba88df66bbfd8f447679645192
Depends-On: Ib3795bcca9d5ec3d68c6443a9854dbc56118ca40
1. Add a configuration option to enable/disable template parameters
encryption.
2. Encrypt hidden parameters before storing them in the database and
decrypt on stack load.
Change-Id: Ie46c6a149f414f655600616da8deee463e55671c
Implements: blueprint encrypt-hidden-parameters
Co-Authored-By: Jason Dunsmore <jasondunsmore@gmail.com>
Adds a new py34 environment in tox.ini which builds off of separate
(test-)requirements-py3.txt files that will just run flake8 for now
and an empty test-file.
partial blueprint heat-python34-support
Change-Id: I5f00a96fc70613ca7014370ec826d0a6a6199fde
Sync with oslo incubator at commit
0fb9dcd54d4e08d9ac8f9764a38c68911b287200
This fixes an issue with heat engine shutdown.
Change-Id: Ie29a7781eb06ee58eb347c924b9110100ddd56f9
Some resource receive IP address as property, this patch adds
custom constraint for IP address format validation.
Implemented: blueprint enhance-property-constraints
Change-Id: Ie4ad71418aa355a4e24ac6c2a33bd85c19c5ef11