All the volume_tasks logic has been redistributed as methods of either
cinder or nova client plugins.
The logic of detaching was simplified and a check for out-of-band
changes is no longer executed.
The old VolumeAttachTask is left in place as it is still used in
creating the AWS::EC2::Instance resource.
Change-Id: I13f8e03ff090dd5f5739e5af231c77d066eb9eac
Partial-Bug: #1393268
There are some improvement of error message and tests
related of bug/1451713.
Change-Id: I78b609c8f1c8d04835f4a9dbadae51e2013fa753
Related-Bug: #1451713
Add validation for cinder volume, should specify only one
of snapshot_id, image, source_volid if don't specify backup_id
or size.
And also add validation of image and imageRef, user can't
set both of them.
Change-Id: Ibc9e75c338d07896e399267c366dd9167229ba9d
Closes-Bug: #1451713
Add property 'read_only' for cinder volume to enable or
disable access mode when creation/updation.
Change-Id: I17ee24ae637a50a7f67395579667f3ba891d848d
Closes-Bug: #1449466
Set resource data 'snapshot_image_id' of server and
'backup_id' of volume immediately after creating the
image and backup while snapshoting. Otherwise there
will image/backup residue in backend.
Change-Id: Id7441f0c9d537b417488c2857019802872239b2e
Closes-Bug: #1448842
Set the failed reason details when snapshot failed for
cinder volume, then user can get the worth information to
know why the snapshot failed.
Change-Id: I1001c41550e5147b96df0846180b587b3c3849cd
Closes-Bug: #1448820
In some cases, there is no information about resource and
section, where Property error raised. This patch improves
StackValidationFailed msg, so this msg look like "Property
error : resource_name.section_name.key_name: error_msg", where
section_name is section, where Property error raised, e.g.
'update_policy'.
Change-Id: Iab2a6acdec254b39983de420ab03f994cff48d89
Closes-bug: #1358512
Implementation for blueprint versioned-objects.
This contains ResourceData.
Co-Authored-By: Grzegorz Grasza <grzegorz.grasza@intel.com>
Co-Authored-By: Michal Jastrzebski (inc0) <michal.jastrzebski@intel.com>
Change-Id: I129f3b891a8efd728ed55c03286dcc1f8b68c4aa
This patch is a prerequiste for moving away from TaskRunner instances.
Currently our mocking in tests relies heavily on our code using the rich cinder
objects returned by cinderclient. The purpose of this patch then is to
first move away from using those and modify mocking in tests accordingly,
so that subsequent patch that removes TaskRunner instances from volume
resources will modify as few tests as possible, which will better prove
its correctness.
Also, modified all deprecated rsrc.cinder() calls to rsrc.client() calls
(using default_client_name) and optimized reuse of clients inside single
methods.
Change-Id: I10c991f9949149c2f4d4b7de00f17ddc4980ae96
Related-Bug: #1393268
This might prevent possible clashes when tests are run in parallel.
Please note, that default stack name generated by
heat/tests/utils.py:parse_stack is now random instead of 'test_stack'.
Please provide an exact (and preferrably unique) stack name to this
function if you want to assert on it.
Those tests that relied on the default 'test_stack' name have been
fixed. Those tests that were explicitly using a rather nonunique name
have been fixed too.
Change-Id: I3b82bbdd1f59020b13c48c929a45411d54ea9085
Split AWS and OS volume tests, move OS volume tests
to heat/tests/openstack/test_volume.py, and move the
aws volume tests to heat/tests/aws/test_volume.py and
move the utils to heat/tests/test_volume_utils.py.
Change-Id: I8119ef2fd2b8d32057f77230d93363c9332d4b52
Implements: blueprint decouple-aws-os-resources
Pavlo Shchelokovskyy